[llvm] [AMDGPU] Replace hardcoded register class IDs with [[#]] (NFC) (PR #185402)

Jay Foad via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 9 08:26:02 PDT 2026


jayfoad wrote:

> > It's not a good idea to manually update checks that have been autogenerated. Your changes will get lost the next time they are regenerated.
> 
> Ah. You're right. It is really bad; keep having these register ID changes in PRs that, most of the time, are unrelated to the actual patch. It would be nice to have this or a similar regex autogenerated by the script to capture register class IDs in the INLINEASM statements.

Well you could try changing the `update` script to detect these numbers and automatically insert `[[#]]` in the check line. But really a better long term solution would be to change the textual MIR format so that it does not contain these numbers in the first place.

https://github.com/llvm/llvm-project/pull/185402


More information about the llvm-commits mailing list