[llvm] [Offload][L0] Add support for OffloadBinary format in L0 plugin (PR #185404)
via llvm-commits
llvm-commits at lists.llvm.org
Mon Mar 9 05:36:22 PDT 2026
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp,h -- offload/plugins-nextgen/common/include/PluginInterface.h offload/plugins-nextgen/common/src/PluginInterface.cpp offload/plugins-nextgen/level_zero/src/L0Program.cpp --diff_from_common_commit
``````````
:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/offload/plugins-nextgen/level_zero/src/L0Program.cpp b/offload/plugins-nextgen/level_zero/src/L0Program.cpp
index ea272ff1c..cf73d4412 100644
--- a/offload/plugins-nextgen/level_zero/src/L0Program.cpp
+++ b/offload/plugins-nextgen/level_zero/src/L0Program.cpp
@@ -223,24 +223,25 @@ Error L0ProgramBuilderTy::buildModules(const std::string_view BuildOptions) {
// Parse inner OffloadBinary
auto InnerBinariesOrErr = llvm::object::OffloadBinary::create(Image);
if (!InnerBinariesOrErr)
- return Plugin::error(ErrorCode::UNKNOWN,
- "Failed to parse inner OffloadBinary: %s",
- llvm::toString(InnerBinariesOrErr.takeError()).c_str());
+ return Plugin::error(
+ ErrorCode::UNKNOWN, "Failed to parse inner OffloadBinary: %s",
+ llvm::toString(InnerBinariesOrErr.takeError()).c_str());
auto &InnerBinaries = *InnerBinariesOrErr;
// Should contain exactly one image
if (InnerBinaries.size() != 1)
return Plugin::error(ErrorCode::UNKNOWN,
- "Expected single inner OffloadBinary entry, got %zu",
- InnerBinaries.size());
+ "Expected single inner OffloadBinary entry, got %zu",
+ InnerBinaries.size());
const llvm::object::OffloadBinary *InnerBinary = InnerBinaries[0].get();
llvm::object::ImageKind ImageKind = InnerBinary->getImageKind();
// Extract image data from inner binary
llvm::StringRef ImageData = InnerBinary->getImage();
- const uint8_t *ImgBegin = reinterpret_cast<const uint8_t *>(ImageData.data());
+ const uint8_t *ImgBegin =
+ reinterpret_cast<const uint8_t *>(ImageData.data());
// Read metadata from inner binary
llvm::StringRef Version = InnerBinary->getString("version");
@@ -249,7 +250,8 @@ Error L0ProgramBuilderTy::buildModules(const std::string_view BuildOptions) {
llvm::StringRef LinkOpts = InnerBinary->getString("link-opts");
ODBG(OLDT_Module) << "Inner OffloadBinary metadata: version=" << Version
- << ", format=" << Format << ", kind=" << ImageKind << "\n";
+ << ", format=" << Format << ", kind=" << ImageKind
+ << "\n";
// Build options string combining BuildOptions with compile/link opts
std::string Options(BuildOptions);
@@ -275,8 +277,8 @@ Error L0ProgramBuilderTy::buildModules(const std::string_view BuildOptions) {
ModuleFormat = ZE_MODULE_FORMAT_NATIVE;
} else {
return Plugin::error(ErrorCode::UNKNOWN,
- "Unsupported image kind %d in inner OffloadBinary",
- static_cast<int>(ImageKind));
+ "Unsupported image kind %d in inner OffloadBinary",
+ static_cast<int>(ImageKind));
}
// Load module into Level Zero
``````````
</details>
https://github.com/llvm/llvm-project/pull/185404
More information about the llvm-commits
mailing list