[llvm] Fixing upper lane return source for X86 intrinsics (PR #185329)

via llvm-commits llvm-commits at lists.llvm.org
Sun Mar 8 17:04:34 PDT 2026


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff origin/main HEAD --extensions h,cpp -- llvm/lib/Target/X86/X86ISelLowering.cpp llvm/lib/Target/X86/X86IntrinsicsInfo.h --diff_from_common_commit
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/llvm/lib/Target/X86/X86ISelLowering.cpp b/llvm/lib/Target/X86/X86ISelLowering.cpp
index 6eac3e899..894c70411 100644
--- a/llvm/lib/Target/X86/X86ISelLowering.cpp
+++ b/llvm/lib/Target/X86/X86ISelLowering.cpp
@@ -27187,7 +27187,8 @@ SDValue X86TargetLowering::LowerINTRINSIC_WO_CHAIN(SDValue Op,
         return SDValue();
 
       return getScalarMaskingNode(DAG.getNode(Opc, dl, VT, Src1, Src2, Src3),
-                                  Mask, PassThru, Subtarget, DAG, /*UpperEltOpSrc=*/0);
+                                  Mask, PassThru, Subtarget, DAG,
+                                  /*UpperEltOpSrc=*/0);
     }
     case INTR_TYPE_3OP_MASK_SAE: {
       SDValue Src1 = Op.getOperand(1);
diff --git a/llvm/lib/Target/X86/X86IntrinsicsInfo.h b/llvm/lib/Target/X86/X86IntrinsicsInfo.h
index e98aea8a6..7c83275e8 100644
--- a/llvm/lib/Target/X86/X86IntrinsicsInfo.h
+++ b/llvm/lib/Target/X86/X86IntrinsicsInfo.h
@@ -611,12 +611,15 @@ static const IntrinsicData IntrinsicsWithoutChain[] = {
                        X86ISD::VMINMAX, 0),
     X86_INTRINSIC_DATA(avx10_mask_vminmaxps256, INTR_TYPE_3OP_MASK_SAE,
                        X86ISD::VMINMAX, 0),
-    X86_INTRINSIC_DATA(avx10_mask_vminmaxsd_round, INTR_TYPE_3OP_SCALAR_MASK_SAE,
-                       X86ISD::VMINMAXS, X86ISD::VMINMAXS_SAE),
-    X86_INTRINSIC_DATA(avx10_mask_vminmaxsh_round, INTR_TYPE_3OP_SCALAR_MASK_SAE,
-                       X86ISD::VMINMAXS, X86ISD::VMINMAXS_SAE),
-    X86_INTRINSIC_DATA(avx10_mask_vminmaxss_round, INTR_TYPE_3OP_SCALAR_MASK_SAE,
-                       X86ISD::VMINMAXS, X86ISD::VMINMAXS_SAE),
+    X86_INTRINSIC_DATA(avx10_mask_vminmaxsd_round,
+                       INTR_TYPE_3OP_SCALAR_MASK_SAE, X86ISD::VMINMAXS,
+                       X86ISD::VMINMAXS_SAE),
+    X86_INTRINSIC_DATA(avx10_mask_vminmaxsh_round,
+                       INTR_TYPE_3OP_SCALAR_MASK_SAE, X86ISD::VMINMAXS,
+                       X86ISD::VMINMAXS_SAE),
+    X86_INTRINSIC_DATA(avx10_mask_vminmaxss_round,
+                       INTR_TYPE_3OP_SCALAR_MASK_SAE, X86ISD::VMINMAXS,
+                       X86ISD::VMINMAXS_SAE),
     X86_INTRINSIC_DATA(avx10_vcomisbf16eq, COMI, X86ISD::COMI, ISD::SETEQ),
     X86_INTRINSIC_DATA(avx10_vcomisbf16ge, COMI, X86ISD::COMI, ISD::SETGE),
     X86_INTRINSIC_DATA(avx10_vcomisbf16gt, COMI, X86ISD::COMI, ISD::SETGT),

``````````

</details>


https://github.com/llvm/llvm-project/pull/185329


More information about the llvm-commits mailing list