[llvm] [SPIR-V] Fix lowering of declarations with hidden visibility (PR #185029)

[Joseph Huber via llvm-commits]

https://github.com/jhuber6 commented:

There's a round-trip for LLVM-IR -> SPIR-V -> LLVM-IR. I suppose this strips the visibility and on the way back it would all become default? That has some implications if we then put it through the AMDGCN pass. For AMDGCN we tend to use `protected` for kernels and globals and hidden for everything else. The main difference is whether or not we expect the user to read it from the code object, because they're essentially shared libraries. Does SPIR-V have a heuristic for this?

https://github.com/llvm/llvm-project/pull/185029