[llvm] [llvm] Prefer the unknown vendor for SerenityOS triples (PR #185026)

Lucas Chollet via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 6 07:32:19 PST 2026


https://github.com/LucasChollet created https://github.com/llvm/llvm-project/pull/185026

No functional change. This patch updates the target-triple unit tests to use the ones that we care about.

@MaskRay as you reviewed the patch that added these tests in the first place.

---

I don't have write permissions here, so I will need help if this is to be accepted.

>From e326455a9e2b1ef380182ef325c6bf79c35c7726 Mon Sep 17 00:00:00 2001
From: Lucas Chollet <lucas.chollet at free.fr>
Date: Wed, 4 Mar 2026 14:47:33 +0100
Subject: [PATCH] [llvm] Prefer the unknown vendor for SerenityOS triples

No functional change. This patch updates the target-triple unit tests
to use the ones that we care about.
---
 llvm/unittests/TargetParser/TripleTest.cpp | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)

diff --git a/llvm/unittests/TargetParser/TripleTest.cpp b/llvm/unittests/TargetParser/TripleTest.cpp
index 7070193c0a129..1a1377b522f8a 100644
--- a/llvm/unittests/TargetParser/TripleTest.cpp
+++ b/llvm/unittests/TargetParser/TripleTest.cpp
@@ -1386,15 +1386,21 @@ TEST(TripleTest, ParsedIDs) {
   EXPECT_EQ(Triple::LiteOS, T.getOS());
   EXPECT_EQ(Triple::UnknownEnvironment, T.getEnvironment());
 
-  T = Triple("x86_64-pc-serenity");
+  T = Triple("x86_64-unknown-serenity");
   EXPECT_EQ(Triple::x86_64, T.getArch());
-  EXPECT_EQ(Triple::PC, T.getVendor());
+  EXPECT_EQ(Triple::UnknownVendor, T.getVendor());
   EXPECT_EQ(Triple::Serenity, T.getOS());
   EXPECT_EQ(Triple::UnknownEnvironment, T.getEnvironment());
 
-  T = Triple("aarch64-pc-serenity");
+  T = Triple("aarch64-unknown-serenity");
   EXPECT_EQ(Triple::aarch64, T.getArch());
-  EXPECT_EQ(Triple::PC, T.getVendor());
+  EXPECT_EQ(Triple::UnknownVendor, T.getVendor());
+  EXPECT_EQ(Triple::Serenity, T.getOS());
+  EXPECT_EQ(Triple::UnknownEnvironment, T.getEnvironment());
+
+  T = Triple("riscv64-unknown-serenity");
+  EXPECT_EQ(Triple::riscv64, T.getArch());
+  EXPECT_EQ(Triple::UnknownVendor, T.getVendor());
   EXPECT_EQ(Triple::Serenity, T.getOS());
   EXPECT_EQ(Triple::UnknownEnvironment, T.getEnvironment());
 



More information about the llvm-commits mailing list