[llvm] expandIS_FPCLASS: Support fcNegative and fcPositive (PR #184788)
via llvm-commits
llvm-commits at lists.llvm.org
Thu Mar 5 20:48:36 PST 2026
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp -- llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp --diff_from_common_commit
``````````
:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp b/llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp
index 680f96d8c..71275d61e 100644
--- a/llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp
+++ b/llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp
@@ -9355,8 +9355,10 @@ SDValue TargetLowering::expandIS_FPCLASS(EVT ResultVT, SDValue Op,
DAG.getNode(ISD::AND, DL, ResultVT, NotNaN, SignBitResult);
}
- bool IsICmpImmLegal = isLegalICmpImmediate(APInt::getAllOnes(IntVTBits).getZExtValue());
- if (!NeedFPCompare && (!DAG.isKnownNeverNaN(Op) || IsICmpImmLegal) && Test == fcPositive) {
+ bool IsICmpImmLegal =
+ isLegalICmpImmediate(APInt::getAllOnes(IntVTBits).getZExtValue());
+ if (!NeedFPCompare && (!DAG.isKnownNeverNaN(Op) || IsICmpImmLegal) &&
+ Test == fcPositive) {
; // (fcPosInf | fcFinite) has better performance.
} else if (Test == fcNegative)
return SignBitResult;
``````````
</details>
https://github.com/llvm/llvm-project/pull/184788
More information about the llvm-commits
mailing list