[llvm] [ORC] Refactor some WaitingOnGraph loops into named methods. NFCI. (PR #184775)

via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 5 04:11:31 PST 2026


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff origin/main HEAD --extensions h -- llvm/include/llvm/ExecutionEngine/Orc/WaitingOnGraph.h --diff_from_common_commit
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/llvm/include/llvm/ExecutionEngine/Orc/WaitingOnGraph.h b/llvm/include/llvm/ExecutionEngine/Orc/WaitingOnGraph.h
index f95838b43..058b2642f 100644
--- a/llvm/include/llvm/ExecutionEngine/Orc/WaitingOnGraph.h
+++ b/llvm/include/llvm/ExecutionEngine/Orc/WaitingOnGraph.h
@@ -116,7 +116,7 @@ public:
     /// Add a mapping from the Defs in this SuperNode to SN (which may or may
     /// not be the same as this).
     void mapDefsTo(ElemToSuperNodeMap &ElemToSN, SuperNode *SN,
-		   bool AbandonOldMapping = false) {
+                   bool AbandonOldMapping = false) {
       assert(!Defs.empty() && "Empty defs!?");
       for (auto &[Container, Elements] : Defs) {
         assert(!Elements.empty() && "Empty elements for container?");
@@ -125,7 +125,7 @@ public:
           ContainerElemToSN[Elem] = SN;
       }
       assert((AbandonOldMapping || !SN->RegisteredElemToSN ||
-	      SN->RegisteredElemToSN == &ElemToSN) &&
+              SN->RegisteredElemToSN == &ElemToSN) &&
              "SN defs split across maps");
       SN->RegisteredElemToSN = &ElemToSN;
     }
@@ -133,7 +133,7 @@ public:
     /// Add a mapping from the Defs in this SuperNode to this.
     /// (Equivalent to `SN.mapDefsTo(ElemToSN, &SN);`)
     void mapDefsToThis(ElemToSuperNodeMap &ElemToSN,
-		       bool AbandonOldMapping = false) {
+                       bool AbandonOldMapping = false) {
       mapDefsTo(ElemToSN, this, AbandonOldMapping);
     }
 

``````````

</details>


https://github.com/llvm/llvm-project/pull/184775


More information about the llvm-commits mailing list