[llvm] [offload] Add properties parameter to olLaunchKernel (PR #184343)
Ćukasz Plewa via llvm-commits
llvm-commits at lists.llvm.org
Thu Mar 5 03:13:56 PST 2026
================
@@ -1058,6 +1092,25 @@ Error olLaunchKernel_impl(ol_queue_handle_t Queue, ol_device_handle_t Device,
LaunchArgs.ThreadLimit[2] = LaunchSizeArgs->GroupSize.z;
LaunchArgs.DynCGroupMem = LaunchSizeArgs->DynSharedMemory;
+ while (Properties && Properties->type != OL_KERNEL_LAUNCH_PROP_TYPE_NONE) {
+ switch (Properties->type) {
+ case OL_KERNEL_LAUNCH_PROP_TYPE_SIZE:
+ LaunchArgs.ArgSizes = const_cast<int64_t *>(
+ reinterpret_cast<const int64_t *>(Properties->data));
----------------
lplewa wrote:
Yeah, this is intended. I wanted to make this API correct. We should use unsigned type for sizes. Unfortunately plugin interface uses int64_t. There are more signed/unsigned miss mach in the plugin interface, but such refactoring is a subject for different patch. For now i propose that at least we create "correct" public interface for liboffload, so we do not have break api later on.
https://github.com/llvm/llvm-project/pull/184343
More information about the llvm-commits
mailing list