[llvm] [WIP][Don't Merge] Check whether lines are covered by existing tests (PR #184637)

[via llvm-commits]

https://github.com/ambergorzynski created https://github.com/llvm/llvm-project/pull/184637

We are confirming that certain lines are not covered by any existing tests. We will submit corresponding tests for each case once we have confirmed this.



>From eb2baa50d5c06254b76ae586fdb17e73f6e654cf Mon Sep 17 00:00:00 2001
From: agorzyns <amber.gorzynski at amd.com>
Date: Wed, 4 Mar 2026 09:32:58 -0600
Subject: [PATCH] [WIP][Don't Merge] Fix formatting

---
 llvm/lib/Target/AMDGPU/AMDGPUMarkLastScratchLoad.cpp |  1 +
 llvm/lib/Target/AMDGPU/SILowerI1Copies.cpp           |  1 +
 llvm/lib/Target/AMDGPU/SILowerSGPRSpills.cpp         |  5 +++--
 llvm/lib/Target/SPIRV/SPIRVEmitIntrinsics.cpp        | 12 +++++++++---
 llvm/lib/Target/SPIRV/SPIRVInstructionSelector.cpp   |  8 ++++++--
 5 files changed, 20 insertions(+), 7 deletions(-)

diff --git a/llvm/lib/Target/AMDGPU/AMDGPUMarkLastScratchLoad.cpp b/llvm/lib/Target/AMDGPU/AMDGPUMarkLastScratchLoad.cpp
index 9b6bb56c85d24..cda01e4228955 100644
--- a/llvm/lib/Target/AMDGPU/AMDGPUMarkLastScratchLoad.cpp
+++ b/llvm/lib/Target/AMDGPU/AMDGPUMarkLastScratchLoad.cpp
@@ -119,6 +119,7 @@ bool AMDGPUMarkLastScratchLoad::run(MachineFunction &MF) {
       // instruction from the next slot.
       if (!MISegmentEnd) {
         SlotIndex NextSlot = Slots.getNextNonNullIndex(Segment.end);
+        abort();
         MISegmentEnd = SI->getInstructionFromIndex(NextSlot);
       }
 
diff --git a/llvm/lib/Target/AMDGPU/SILowerI1Copies.cpp b/llvm/lib/Target/AMDGPU/SILowerI1Copies.cpp
index 0b8c71a4a2453..871c5e7404881 100644
--- a/llvm/lib/Target/AMDGPU/SILowerI1Copies.cpp
+++ b/llvm/lib/Target/AMDGPU/SILowerI1Copies.cpp
@@ -644,6 +644,7 @@ bool Vreg1LoweringHelper::lowerCopiesToI1() {
       unsigned FoundLoopLevel = LF.findLoop(PostDomBound);
       if (FoundLoopLevel) {
         SSAUpdater.Initialize(DstReg);
+        abort();
         SSAUpdater.AddAvailableValue(&MBB, DstReg);
         LF.addLoopEntries(FoundLoopLevel, SSAUpdater, *MRI, LaneMaskRegAttrs);
 
diff --git a/llvm/lib/Target/AMDGPU/SILowerSGPRSpills.cpp b/llvm/lib/Target/AMDGPU/SILowerSGPRSpills.cpp
index 196e551932659..045cf573dcdf4 100644
--- a/llvm/lib/Target/AMDGPU/SILowerSGPRSpills.cpp
+++ b/llvm/lib/Target/AMDGPU/SILowerSGPRSpills.cpp
@@ -340,9 +340,10 @@ void SILowerSGPRSpills::updateLaneVGPRDomInstr(
       // Find the common dominator block between PrevInsertPt and the
       // current spill.
       DomMBB = MDT->findNearestCommonDominator(DomMBB, MBB);
-      if (DomMBB == MBB)
+      if (DomMBB == MBB) {
         I->second = InsertPt;
-      else if (DomMBB != PrevInsertPt->getParent())
+        abort();
+      } else if (DomMBB != PrevInsertPt->getParent())
         I->second = &(*DomMBB->getFirstTerminator());
     }
   }
diff --git a/llvm/lib/Target/SPIRV/SPIRVEmitIntrinsics.cpp b/llvm/lib/Target/SPIRV/SPIRVEmitIntrinsics.cpp
index 04add49846350..1d46ad2546e26 100644
--- a/llvm/lib/Target/SPIRV/SPIRVEmitIntrinsics.cpp
+++ b/llvm/lib/Target/SPIRV/SPIRVEmitIntrinsics.cpp
@@ -759,8 +759,10 @@ Type *SPIRVEmitIntrinsics::getGEPType(GetElementPtrInst *Ref) {
   // useful here
   if (isNestedPointer(Ref->getSourceElementType())) {
     Ty = Ref->getSourceElementType();
-    for (Use &U : drop_begin(Ref->indices()))
+    for (Use &U : drop_begin(Ref->indices())) {
       Ty = GetElementPtrInst::getTypeAtIndex(Ty, U.get());
+      abort();
+    }
   } else {
     Ty = Ref->getResultElementType();
   }
@@ -1134,8 +1136,10 @@ void SPIRVEmitIntrinsics::deduceOperandElementTypeFunctionPointer(
       IsNewFTy = true;
       RetTy =
           getTypedPointerWrapper(ElemTy, getPointerAddressSpace(CI->getType()));
-      if (isTodoType(CI))
+      if (isTodoType(CI)) {
         IsIncomplete = true;
+        abort();
+      }
     } else {
       IsIncomplete = true;
     }
@@ -2658,8 +2662,10 @@ Type *SPIRVEmitIntrinsics::deduceFunParamElementType(
       return KnownTy;
     // try to deduce from the operand itself
     Visited.clear();
-    if (Type *Ty = deduceElementTypeHelper(OpArg, Visited, false))
+    if (Type *Ty = deduceElementTypeHelper(OpArg, Visited, false)) {
+      abort();
       return Ty;
+    }
     // search in actual parameter's users
     for (User *OpU : OpArg->users()) {
       Instruction *Inst = dyn_cast<Instruction>(OpU);
diff --git a/llvm/lib/Target/SPIRV/SPIRVInstructionSelector.cpp b/llvm/lib/Target/SPIRV/SPIRVInstructionSelector.cpp
index dd0830bb879f5..019df1489a10c 100644
--- a/llvm/lib/Target/SPIRV/SPIRVInstructionSelector.cpp
+++ b/llvm/lib/Target/SPIRV/SPIRVInstructionSelector.cpp
@@ -2356,10 +2356,14 @@ static unsigned getPtrCmpOpcode(unsigned Pred) {
 static unsigned getBoolCmpOpcode(unsigned PredNum) {
   auto Pred = static_cast<CmpInst::Predicate>(PredNum);
   switch (Pred) {
-  case CmpInst::ICMP_EQ:
+  case CmpInst::ICMP_EQ: {
+    abort();
     return SPIRV::OpLogicalEqual;
-  case CmpInst::ICMP_NE:
+  }
+  case CmpInst::ICMP_NE: {
+    abort();
     return SPIRV::OpLogicalNotEqual;
+  }
   default:
     llvm_unreachable("Unknown predicate type for Bool comparison");
   }