[llvm] [SPIR-V] Complete SPV_INTEL_16bit_atomics extension support (PR #184312)
Juan Manuel Martinez CaamaƱo via llvm-commits
llvm-commits at lists.llvm.org
Wed Mar 4 03:41:55 PST 2026
================
@@ -1622,10 +1622,44 @@ void addInstrRequirements(const MachineInstr &MI,
assert(InstrPtr->getOperand(1).isReg() && "Unexpected operand in atomic");
Register TypeReg = InstrPtr->getOperand(1).getReg();
SPIRVTypeInst TypeDef = MRI.getVRegDef(TypeReg);
+ unsigned Op = MI.getOpcode();
+
if (TypeDef->getOpcode() == SPIRV::OpTypeInt) {
unsigned BitWidth = TypeDef->getOperand(1).getImm();
if (BitWidth == 64)
Reqs.addCapability(SPIRV::Capability::Int64Atomics);
+ else if (BitWidth == 16) {
+ if (!ST.canUseExtension(SPIRV::Extension::SPV_INTEL_16bit_atomics))
+ report_fatal_error(
+ "16-bit integer atomic operations require the following SPIR-V "
+ "extension: SPV_INTEL_16bit_atomics",
+ false);
+ Reqs.addExtension(SPIRV::Extension::SPV_INTEL_16bit_atomics);
+ switch (Op) {
+ case SPIRV::OpAtomicLoad:
+ case SPIRV::OpAtomicStore:
+ case SPIRV::OpAtomicExchange:
+ case SPIRV::OpAtomicCompareExchange:
+ case SPIRV::OpAtomicCompareExchangeWeak:
+ Reqs.addCapability(
+ SPIRV::Capability::AtomicInt16CompareExchangeINTEL);
+ break;
+ default:
+ Reqs.addCapability(SPIRV::Capability::Int16AtomicsINTEL);
+ break;
+ }
+ }
+ } else if (isBFloat16Type(TypeDef)) {
+ if (Op == SPIRV::OpAtomicLoad || Op == SPIRV::OpAtomicStore ||
+ Op == SPIRV::OpAtomicExchange) {
----------------
jmmartinez wrote:
Aesthetic. Mostly to stop repeating `Op == ` and have something that can be easier to refactor later.
With `is_contained`, we can move the list into a local variable and keep the length of the statements shorter.
https://github.com/llvm/llvm-project/pull/184312
More information about the llvm-commits
mailing list