[llvm] [Analysis][NFC] Store CallbackVH in vector, not in map (PR #184323)

[Nikita Popov via llvm-commits]

nikic wrote:

@aengelke Yes, updating the analyses explicitly is generally better. I believe that we used to have "support" for using BFI/BPI in loop pass managers without it being explicitly updated, but predictably the impact of stale BFI/BPI was worse than the benefit of using it in the first place. With that gone, I do think we should aim for passes either updating BFI/BPI properly, or not using them at all. It may be somehow hard to get there though, as probably lots of passes are relying on the value handles now...

https://github.com/llvm/llvm-project/pull/184323