[llvm] [InstCombine] Fix non-convergence with freeze/phi folding (PR #182647)
via llvm-commits
llvm-commits at lists.llvm.org
Fri Feb 20 18:52:10 PST 2026
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp -- llvm/lib/Transforms/InstCombine/InstructionCombining.cpp --diff_from_common_commit
``````````
:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/llvm/lib/Transforms/InstCombine/InstructionCombining.cpp b/llvm/lib/Transforms/InstCombine/InstructionCombining.cpp
index 3a44253f8..a8e98a451 100644
--- a/llvm/lib/Transforms/InstCombine/InstructionCombining.cpp
+++ b/llvm/lib/Transforms/InstCombine/InstructionCombining.cpp
@@ -1982,7 +1982,8 @@ Instruction *InstCombinerImpl::foldOpIntoPhi(Instruction &I, PHINode *PN,
// Avoid repeatedly sinking a freeze into a PHI only for some of the newly
// created incoming freezes to be trivially removable again. That pattern
- // can cause oscillation between freeze(phi(...)) and phi(..., freeze(x), ...).
+ // can cause oscillation between freeze(phi(...)) and phi(..., freeze(x),
+ // ...).
if (isa<FreezeInst>(&I) && isGuaranteedNotToBeUndefOrPoison(InVal))
return nullptr;
``````````
</details>
https://github.com/llvm/llvm-project/pull/182647
More information about the llvm-commits
mailing list