[llvm] b2eb876 - [AMDGPU][NFC] Use range-based for loops in KD reserved bytes checks (#182340)
via llvm-commits
llvm-commits at lists.llvm.org
Fri Feb 20 07:53:40 PST 2026
Author: Son Tuan Vu
Date: 2026-02-20T07:53:36-08:00
New Revision: b2eb876ca6bde79ef3755b38f252bf05914dd7f7
URL: https://github.com/llvm/llvm-project/commit/b2eb876ca6bde79ef3755b38f252bf05914dd7f7
DIFF: https://github.com/llvm/llvm-project/commit/b2eb876ca6bde79ef3755b38f252bf05914dd7f7.diff
LOG: [AMDGPU][NFC] Use range-based for loops in KD reserved bytes checks (#182340)
Added:
Modified:
llvm/lib/Target/AMDGPU/Disassembler/AMDGPUDisassembler.cpp
Removed:
################################################################################
diff --git a/llvm/lib/Target/AMDGPU/Disassembler/AMDGPUDisassembler.cpp b/llvm/lib/Target/AMDGPU/Disassembler/AMDGPUDisassembler.cpp
index 2309a56f612f1..9c7b4ec369db0 100644
--- a/llvm/lib/Target/AMDGPU/Disassembler/AMDGPUDisassembler.cpp
+++ b/llvm/lib/Target/AMDGPU/Disassembler/AMDGPUDisassembler.cpp
@@ -2684,8 +2684,8 @@ Expected<bool> AMDGPUDisassembler::decodeKernelDescriptorDirective(
case amdhsa::RESERVED0_OFFSET:
// 4 reserved bytes, must be 0.
ReservedBytes = DE.getBytes(Cursor, 4);
- for (int I = 0; I < 4; ++I) {
- if (ReservedBytes[I] != 0)
+ for (char B : ReservedBytes) {
+ if (B != 0)
return createReservedKDBytesError(amdhsa::RESERVED0_OFFSET, 4);
}
return true;
@@ -2700,8 +2700,8 @@ Expected<bool> AMDGPUDisassembler::decodeKernelDescriptorDirective(
case amdhsa::RESERVED1_OFFSET:
// 20 reserved bytes, must be 0.
ReservedBytes = DE.getBytes(Cursor, 20);
- for (int I = 0; I < 20; ++I) {
- if (ReservedBytes[I] != 0)
+ for (char B : ReservedBytes) {
+ if (B != 0)
return createReservedKDBytesError(amdhsa::RESERVED1_OFFSET, 20);
}
return true;
@@ -2783,8 +2783,8 @@ Expected<bool> AMDGPUDisassembler::decodeKernelDescriptorDirective(
case amdhsa::RESERVED3_OFFSET:
// 4 bytes from here are reserved, must be 0.
ReservedBytes = DE.getBytes(Cursor, 4);
- for (int I = 0; I < 4; ++I) {
- if (ReservedBytes[I] != 0)
+ for (char B : ReservedBytes) {
+ if (B != 0)
return createReservedKDBytesError(amdhsa::RESERVED3_OFFSET, 4);
}
return true;
More information about the llvm-commits
mailing list