[llvm] [Support][NFC] Avoid weak vtable warning for JSON ParseError (PR #182511)
Alexis Engelke via llvm-commits
llvm-commits at lists.llvm.org
Fri Feb 20 07:19:08 PST 2026
https://github.com/aengelke created https://github.com/llvm/llvm-project/pull/182511
None
>From 37f97cea2df6e1f783732ff63ae0420eca5bfa75 Mon Sep 17 00:00:00 2001
From: Alexis Engelke <engelke at in.tum.de>
Date: Fri, 20 Feb 2026 15:17:28 +0000
Subject: [PATCH] [Support][NFC] Avoid weak vtable for JSON ParseError
---
llvm/include/llvm/Support/JSON.h | 4 +---
llvm/lib/Support/JSON.cpp | 5 +++++
2 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/llvm/include/llvm/Support/JSON.h b/llvm/include/llvm/Support/JSON.h
index ad4f891f99bb7..27862eb7ab6bb 100644
--- a/llvm/include/llvm/Support/JSON.h
+++ b/llvm/include/llvm/Support/JSON.h
@@ -918,9 +918,7 @@ class ParseError : public llvm::ErrorInfo<ParseError> {
LLVM_ABI static char ID;
ParseError(const char *Msg, unsigned Line, unsigned Column, unsigned Offset)
: Msg(Msg), Line(Line), Column(Column), Offset(Offset) {}
- void log(llvm::raw_ostream &OS) const override {
- OS << llvm::formatv("[{0}:{1}, byte={2}]: {3}", Line, Column, Offset, Msg);
- }
+ void log(llvm::raw_ostream &OS) const override;
std::error_code convertToErrorCode() const override {
return llvm::inconvertibleErrorCode();
}
diff --git a/llvm/lib/Support/JSON.cpp b/llvm/lib/Support/JSON.cpp
index e9fd8f8fae1fa..33901a96d0ec5 100644
--- a/llvm/lib/Support/JSON.cpp
+++ b/llvm/lib/Support/JSON.cpp
@@ -688,8 +688,13 @@ Expected<Value> parse(StringRef JSON) {
return std::move(E);
return P.takeError();
}
+
char ParseError::ID = 0;
+void ParseError::log(llvm::raw_ostream &OS) const {
+ OS << llvm::formatv("[{0}:{1}, byte={2}]: {3}", Line, Column, Offset, Msg);
+}
+
bool isUTF8(llvm::StringRef S, size_t *ErrOffset) {
// Fast-path for ASCII, which is valid UTF-8.
if (LLVM_LIKELY(isASCII(S)))
More information about the llvm-commits
mailing list