[clang] [llvm] [clang] Simplify usage of FileManager::makeAbsolutePath (PR #182360)

[Cyndy Ishida via llvm-commits]

================
@@ -664,6 +664,17 @@ void ModuleDepCollectorPP::EndOfMainFile() {
     MDC.Consumer.handlePrebuiltModuleDependency(I.second);
 }
 
+static StringRef makeAbsoluteAndCanonicalize(CompilerInstance &CI,
+                                             StringRef Path,
+                                             SmallVectorImpl<char> &Storage) {
+  if (llvm::sys::path::is_absolute(Path) &&
+      !llvm::sys::path::is_style_windows(llvm::sys::path::Style::native))
+    return Path;
----------------
cyndyishida wrote:

> remove this optimization all together to have consistent behavior.

Can one actually reasonably do that if it's an optimization? Or are you saying you expect it to be negligible?

https://github.com/llvm/llvm-project/pull/182360