[llvm] [LV] Support argmin/argmax with strict predicates. (PR #170223)

[via llvm-commits]

github-actions[bot] wrote:

<!--PREMERGE ADVISOR COMMENT: Windows-->
# :window: Windows x64 Test Results

* 127976 tests passed
* 2920 tests skipped

All executed tests passed, but another part of the build **failed**. Click on a failure below to see the details.

<details>
<summary>[code=4294967295] tools/clang/tools/extra/unittests/clang-doc/ClangDocTests.exe</summary>

```
FAILED: [code=4294967295] tools/clang/tools/extra/unittests/clang-doc/ClangDocTests.exe
cmd.exe /C "cd . && C:\BuildTools\Common7\IDE\CommonExtensions\Microsoft\CMake\CMake\bin\cmake.exe -E vs_link_exe --intdir=tools\clang\tools\extra\unittests\clang-doc\CMakeFiles\ClangDocTests.dir --rc="C:\Program Files (x86)\Windows Kits\10\bin\10.0.19041.0\x64\rc.exe" --mt="C:\Program Files (x86)\Windows Kits\10\bin\10.0.19041.0\x64\mt.exe" --manifests  -- C:\clang\clang-msvc\bin\lld-link.exe /nologo @CMakeFiles\ClangDocTests.rsp  /out:tools\clang\tools\extra\unittests\clang-doc\ClangDocTests.exe /implib:tools\clang\tools\extra\unittests\clang-doc\ClangDocTests.lib /pdb:tools\clang\tools\extra\unittests\clang-doc\ClangDocTests.pdb /version:0.0 /MANIFEST:NO /STACK:10000000 /INCREMENTAL:NO /subsystem:console  && cd ."
LINK: command "C:\clang\clang-msvc\bin\lld-link.exe /nologo @CMakeFiles\ClangDocTests.rsp /out:tools\clang\tools\extra\unittests\clang-doc\ClangDocTests.exe /implib:tools\clang\tools\extra\unittests\clang-doc\ClangDocTests.lib /pdb:tools\clang\tools\extra\unittests\clang-doc\ClangDocTests.pdb /version:0.0 /MANIFEST:NO /STACK:10000000 /INCREMENTAL:NO /subsystem:console" failed (exit code 1) with the following output:
lld-link: error: undefined symbol: public: __cdecl clang::DiagnosticIDs::DiagnosticIDs(void)
>>> referenced by tools\clang\tools\extra\unittests\clang-doc\CMakeFiles\ClangDocTests.dir\ClangDocTest.cpp.obj:(protected: __cdecl clang::doc::ClangDocContextTest::ClangDocContextTest(void))
>>> referenced by clangFrontend.lib(CompilerInvocation.cpp.obj):(bool __cdecl RoundTrip(class llvm::function_ref<bool __cdecl(class clang::CompilerInvocation &, class llvm::ArrayRef<char const *>, class clang::DiagnosticsEngine &, char const *)>, class llvm::function_ref<void __cdecl(class clang::CompilerInvocation &, class llvm::SmallVectorImpl<char const *> &, class llvm::function_ref<char const * __cdecl(class llvm::Twine const &)>)>, class clang::CompilerInvocation &, class clang::CompilerInvocation &, class llvm::ArrayRef<char const *>, class clang::DiagnosticsEngine &, char const *, bool, bool))
>>> referenced by clangFrontend.lib(CompilerInvocation.cpp.obj):(bool __cdecl clang::ParseDiagnosticArgs(class clang::DiagnosticOptions &, class llvm::opt::ArgList &, class clang::DiagnosticsEngine *, bool))
>>> referenced 4 more times

lld-link: error: undefined symbol: public: __cdecl clang::DiagnosticsEngine::DiagnosticsEngine(class llvm::IntrusiveRefCntPtr<class clang::DiagnosticIDs>, class clang::DiagnosticOptions &, class clang::DiagnosticConsumer *, bool)
>>> referenced by tools\clang\tools\extra\unittests\clang-doc\CMakeFiles\ClangDocTests.dir\ClangDocTest.cpp.obj:(protected: __cdecl clang::doc::ClangDocContextTest::ClangDocContextTest(void))
>>> referenced by clangSerialization.lib(ASTReader.cpp.obj):(public: virtual bool __cdecl clang::PCHValidator::ReadDiagnosticOptions(class clang::DiagnosticOptions &, class llvm::StringRef, bool))
>>> referenced by clangFrontend.lib(CompilerInvocation.cpp.obj):(bool __cdecl RoundTrip(class llvm::function_ref<bool __cdecl(class clang::CompilerInvocation &, class llvm::ArrayRef<char const *>, class clang::DiagnosticsEngine &, char const *)>, class llvm::function_ref<void __cdecl(class clang::CompilerInvocation &, class llvm::SmallVectorImpl<char const *> &, class llvm::function_ref<char const * __cdecl(class llvm::Twine const &)>)>, class clang::CompilerInvocation &, class clang::CompilerInvocation &, class llvm::ArrayRef<char const *>, class clang::DiagnosticsEngine &, char const *, bool, bool))
>>> referenced 6 more times

lld-link: error: undefined symbol: public: __cdecl clang::DiagnosticsEngine::~DiagnosticsEngine(void)
>>> referenced by tools\clang\tools\extra\unittests\clang-doc\CMakeFiles\ClangDocTests.dir\ClangDocTest.cpp.obj:(protected: virtual __cdecl clang::doc::ClangDocContextTest::~ClangDocContextTest(void))
>>> referenced by clangFrontend.lib(ASTUnit.cpp.obj):(public: __cdecl clang::ASTUnit::~ASTUnit(void))
>>> referenced by clangFrontend.lib(ASTUnit.cpp.obj):(private: static void __cdecl clang::ASTUnit::ConfigureDiags(class llvm::IntrusiveRefCntPtr<class clang::DiagnosticsEngine>, class clang::ASTUnit &, enum clang::CaptureDiagsKind))
>>> referenced 28 more times

lld-link: error: undefined symbol: public: __cdecl clang::DiagnosticIDs::~DiagnosticIDs(void)
>>> referenced by tools\clang\tools\extra\unittests\clang-doc\CMakeFiles\ClangDocTests.dir\ClangDocTest.cpp.obj:(protected: virtual __cdecl clang::doc::ClangDocContextTest::~ClangDocContextTest(void))
>>> referenced by clangSerialization.lib(ASTReader.cpp.obj):(public: virtual bool __cdecl clang::PCHValidator::ReadDiagnosticOptions(class clang::DiagnosticOptions &, class llvm::StringRef, bool))

lld-link: error: undefined symbol: public: virtual __cdecl clang::DiagnosticConsumer::~DiagnosticConsumer(void)
>>> referenced by tools\clang\tools\extra\unittests\clang-doc\CMakeFiles\ClangDocTests.dir\ClangDocTest.cpp.obj:(public: virtual void * __cdecl clang::IgnoringDiagConsumer::`scalar deleting dtor'(unsigned int))
>>> referenced by clangFrontend.lib(ASTUnit.cpp.obj):(public: __cdecl clang::CaptureDroppedDiagnostics::~CaptureDroppedDiagnostics(void))
>>> referenced by clangFrontend.lib(ASTUnit.cpp.obj):(private: class std::unique_ptr<class llvm::MemoryBuffer, struct std::default_delete<class llvm::MemoryBuffer>> __cdecl clang::ASTUnit::getMainBufferWithPrecompiledPreamble(class std::shared_ptr<class clang::PCHContainerOperations>, class clang::CompilerInvocation &, class llvm::IntrusiveRefCntPtr<class llvm::vfs::FileSystem>, bool, unsigned int))
>>> referenced 11 more times

lld-link: error: undefined symbol: public: virtual bool __cdecl clang::DiagnosticConsumer::IncludeInDiagnosticCounts(void) const
>>> referenced by tools\clang\tools\extra\unittests\clang-doc\CMakeFiles\ClangDocTests.dir\ClangDocTest.cpp.obj:(const clang::IgnoringDiagConsumer::`vftable')
>>> referenced by clangFrontend.lib(ASTUnit.cpp.obj):(const clang::FilterAndStoreDiagnosticConsumer::`vftable')
>>> referenced by clangFrontend.lib(CompilerInvocation.cpp.obj):(const clang::TextDiagnosticBuffer::`vftable')
>>> referenced 5 more times

lld-link: error: undefined symbol: private: virtual void __cdecl clang::IgnoringDiagConsumer::anchor(void)
>>> referenced by tools\clang\tools\extra\unittests\clang-doc\CMakeFiles\ClangDocTests.dir\ClangDocTest.cpp.obj:(const clang::IgnoringDiagConsumer::`vftable')
>>> referenced by clangFrontend.lib(CompilerInvocation.cpp.obj)

lld-link: error: undefined symbol: class std::basic_string<char, struct std::char_traits<char>, class std::allocator<char>> __cdecl clang::getClangToolFullVersion(class llvm::StringRef)
>>> referenced by tools\clang\tools\extra\unittests\clang-doc\CMakeFiles\ClangDocTests.dir\HTMLGeneratorTest.cpp.obj:(_GLOBAL__sub_I_HTMLGeneratorTest.cpp)
>>> referenced by clangDriver.lib(Driver.cpp.obj):(public: void __cdecl clang::driver::Driver::PrintVersion(class clang::driver::Compilation const &, class llvm::raw_ostream &) const)

lld-link: error: undefined symbol: char const * __cdecl clang::getOperatorSpelling(enum clang::OverloadedOperatorKind)
>>> referenced by clangAST.lib(TemplateName.cpp.obj):(public: void __cdecl clang::DependentTemplateStorage::print(class llvm::raw_ostream &, struct clang::PrintingPolicy const &) const)
>>> referenced by clangAST.lib(TemplateName.cpp.obj):(public: void __cdecl clang::DependentTemplateStorage::print(class llvm::raw_ostream &, struct clang::PrintingPolicy const &) const)
>>> referenced by clangAST.lib(OpenMPClause.cpp.obj):(public: void __cdecl clang::OMPClausePrinter::VisitOMPReductionClause(class clang::OMPReductionClause *))
>>> referenced 12 more times

lld-link: error: undefined symbol: public: class llvm::StringRef __cdecl clang::IdentifierInfo::deuglifiedName(void) const
>>> referenced by clangAST.lib(TemplateName.cpp.obj):(public: void __cdecl clang::TemplateName::print(class llvm::raw_ostream &, struct clang::PrintingPolicy const &, enum clang::TemplateName::Qualified) const)
>>> referenced by clangAST.lib(TypePrinter.cpp.obj):(public: void __cdecl `anonymous namespace'::TypePrinter::printSubstTemplateTypeParmPackBefore(class clang::SubstTemplateTypeParmPackType const *, class llvm::raw_ostream &))
>>> referenced by clangAST.lib(TypePrinter.cpp.obj):(public: void __cdecl `anonymous namespace'::TypePrinter::printTemplateTypeParmBefore(class clang::TemplateTypeParmType const *, class llvm::raw_ostream &))
>>> referenced 14 more times

lld-link: error: undefined symbol: public: __cdecl clang::LangOptions::LangOptions(void)
>>> referenced by clangAST.lib(TemplateName.cpp.obj):(class clang::StreamingDiagnostic const & __cdecl clang::operator<<(class clang::StreamingDiagnostic const &, class clang::TemplateName))
>>> referenced by clangAST.lib(OpenMPClause.cpp.obj):(class llvm::raw_ostream & __cdecl clang::operator<<(class llvm::raw_ostream &, class clang::OMPTraitInfo const &))
>>> referenced by clangAST.lib(OpenMPClause.cpp.obj):(class llvm::raw_ostream & __cdecl clang::operator<<(class llvm::raw_ostream &, class clang::OMPTraitInfo const *))
>>> referenced 30 more times

lld-link: error: undefined symbol: private: static enum clang::ObjCMethodFamily __cdecl clang::Selector::getMethodFamilyImpl(class clang::Selector)
>>> referenced by clangAST.lib(DeclObjC.cpp.obj):(public: enum clang::ObjCMethodFamily __cdecl clang::ObjCMethodDecl::getMethodFamily(void) const)
>>> referenced by clangAST.lib(Expr.cpp.obj):(public: enum clang::ObjCMethodFamily __cdecl clang::ObjCMessageExpr::getMethodFamily(void) const)
>>> referenced by clangSema.lib(SemaDeclObjC.cpp.obj):(public: class clang::Decl * __cdecl clang::SemaObjC::ActOnMethodDeclaration(class clang::Scope *, class clang::SourceLocation, class clang::SourceLocation, enum clang::tok::TokenKind, class clang::ObjCDeclSpec &, class clang::OpaquePtr<class clang::QualType>, class llvm::ArrayRef<class clang::SourceLocation>, class clang::Selector, class clang::ParmVarDecl **, struct clang::DeclaratorChunk::ParamInfo *, unsigned int, class clang::ParsedAttributesView const &, enum clang::tok::ObjCKeywordKind, bool, bool))
>>> referenced 7 more times

lld-link: error: undefined symbol: public: unsigned int __cdecl clang::Selector::getNumArgs(void) const
>>> referenced by clangAST.lib(DeclObjC.cpp.obj):(public: unsigned int __cdecl clang::ObjCMethodDecl::getNumSelectorLocs(void) const)
>>> referenced by clangAST.lib(DeclObjC.cpp.obj):(public: class clang::ObjCPropertyDecl const * __cdecl clang::ObjCMethodDecl::findPropertyDecl(bool) const)
>>> referenced by clangAST.lib(ASTContext.cpp.obj):(public: class clang::ParmVarDecl const *const * __cdecl clang::ObjCMethodDecl::sel_param_end(void) const)
>>> referenced 41 more times

lld-link: error: undefined symbol: public: class clang::Module const * __cdecl clang::Module::getTopLevelModule(void) const
>>> referenced by clangAST.lib(DeclBase.cpp.obj):(public: class clang::Module * __cdecl clang::Decl::getTopLevelOwningNamedModule(void) const)
>>> referenced by clangAST.lib(DeclBase.cpp.obj):(public: class clang::Module * __cdecl clang::Decl::getTopLevelOwningNamedModule(void) const)
>>> referenced by clangAST.lib(DeclBase.cpp.obj):(public: class clang::Module * __cdecl clang::Decl::getTopLevelOwningNamedModule(void) const)
>>> referenced 71 more times

lld-link: error: undefined symbol: public: void __cdecl clang::SourceLocation::print(class llvm::raw_ostream &, class clang::SourceManager const &) const
>>> referenced by clangAST.lib(DeclBase.cpp.obj):(public: virtual void __cdecl clang::PrettyStackTraceDecl::print(class llvm::raw_ostream &) const)
>>> referenced by clangAST.lib(Decl.cpp.obj):(public: virtual void __cdecl clang::PrettyDeclStackTraceEntry::print(class llvm::raw_ostream &) const)
>>> referenced by clangAST.lib(CommentLexer.cpp.obj):(public: void __cdecl clang::comments::Token::dump(class clang::comments::Lexer const &, class clang::SourceManager const &) const)
>>> referenced 8 more times

lld-link: error: undefined symbol: public: bool __cdecl clang::TargetInfo::validateOutputConstraint(struct clang::TargetInfo::ConstraintInfo &) const
>>> referenced by clangAST.lib(Stmt.cpp.obj):(public: class std::basic_string<char, struct std::char_traits<char>, class std::allocator<char>> __cdecl clang::AsmStmt::addVariableConstraints(class llvm::StringRef, class clang::Expr const &, class clang::TargetInfo const &, bool, class llvm::function_ref<void __cdecl(class clang::Stmt const *, class llvm::StringRef)>, class std::basic_string<char, struct std::char_traits<char>, class std::allocator<char>> *) const)
>>> referenced by clangSema.lib(SemaStmtAsm.cpp.obj):(public: class clang::ActionResult<class clang::Stmt *, 1> __cdecl clang::Sema::ActOnGCCAsmStmt(class clang::SourceLocation, bool, bool, unsigned int, unsigned int, class clang::IdentifierInfo **, class llvm::MutableArrayRef<class clang::Expr *>, class llvm::MutableArrayRef<class clang::Expr *>, class clang::Expr *, class llvm::MutableArrayRef<class clang::Expr *>, unsigned int, class clang::SourceLocation))

lld-link: error: undefined symbol: public: class llvm::StringRef __cdecl clang::TargetInfo::getNormalizedGCCRegisterName(class llvm::StringRef, bool) const
>>> referenced by clangAST.lib(Stmt.cpp.obj):(public: class std::basic_string<char, struct std::char_traits<char>, class std::allocator<char>> __cdecl clang::AsmStmt::addVariableConstraints(class llvm::StringRef, class clang::Expr const &, class clang::TargetInfo const &, bool, class llvm::function_ref<void __cdecl(class clang::Stmt const *, class llvm::StringRef)>, class std::basic_string<char, struct std::char_traits<char>, class std::allocator<char>> *) const)
>>> referenced by clangSema.lib(SemaStmtAsm.cpp.obj):(class clang::SourceLocation __cdecl getClobberConflictLocation(class llvm::MutableArrayRef<class clang::Expr *>, class clang::Expr **, class clang::Expr **, int, unsigned int, class clang::TargetInfo const &, class clang::ASTContext &))
>>> referenced by clangSema.lib(SemaStmtAsm.cpp.obj):(class clang::SourceLocation __cdecl getClobberConflictLocation(class llvm::MutableArrayRef<class clang::Expr *>, class clang::Expr **, class clang::Expr **, int, unsigned int, class clang::TargetInfo const &, class clang::ASTContext &))

lld-link: error: undefined symbol: unsigned short const *const clang::charinfo::InfoTable
>>> referenced by clangAST.lib(Stmt.cpp.obj):(public: class std::basic_string<char, struct std::char_traits<char>, class std::allocator<char>> __cdecl clang::GCCAsmStmt::generateAsmString(class clang::ASTContext const &) const)
>>> referenced by clangAST.lib(Stmt.cpp.obj):(public: class std::basic_string<char, struct std::char_traits<char>, class std::allocator<char>> __cdecl clang::GCCAsmStmt::generateAsmString(class clang::ASTContext const &) const)
>>> referenced by clangAST.lib(Stmt.cpp.obj):(public: class std::basic_string<char, struct std::char_traits<char>, class std::allocator<char>> __cdecl clang::GCCAsmStmt::generateAsmString(class clang::ASTContext const &) const)
>>> referenced 152 more times

lld-link: error: undefined symbol: char const * __cdecl clang::getOpenMPSimpleClauseTypeName(enum llvm::omp::Clause, unsigned int)
>>> referenced by clangAST.lib(OpenMPClause.cpp.obj):(public: void __cdecl clang::OMPClausePrinter::VisitOMPNumThreadsClause(class clang::OMPNumThreadsClause *))
>>> referenced by clangAST.lib(OpenMPClause.cpp.obj):(public: void __cdecl clang::OMPClausePrinter::VisitOMPDefaultClause(class clang::OMPDefaultClause *))
>>> referenced by clangAST.lib(OpenMPClause.cpp.obj):(public: void __cdecl clang::OMPClausePrinter::VisitOMPThreadsetClause(class clang::OMPThreadsetClause *))
>>> referenced 52 more times

lld-link: error: undefined symbol: char const * __cdecl clang::getOpenMPDefaultVariableCategoryName(unsigned int)
>>> referenced by clangAST.lib(OpenMPClause.cpp.obj):(public: void __cdecl clang::OMPClausePrinter::VisitOMPDefaultClause(class clang::OMPDefaultClause *))
>>> referenced by clangAST.lib(OpenMPClause.cpp.obj):(public: void __cdecl clang::OMPClausePrinter::VisitOMPDefaultClause(class clang::OMPDefaultClause *))

lld-link: error: too many errors emitted, stopping now (use /errorlimit:0 to see all errors)
```
</details>

If these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the `infrastructure` label.

https://github.com/llvm/llvm-project/pull/170223