[llvm] [AMDGPU][SIInsertWaitcnts][NFC] Drop MaxCounter member variable (PR #181092)

[Sameer Sahasrabuddhe via llvm-commits]

https://github.com/ssahasra requested changes to this pull request.

I am opposed to this replacement of `MaxCounter` with a function that gets called in many places. It obscures the simple fact that MaxCounter is a constant for each run of the pass, and instead creates the impression that it needs to be determined dynamically. I don't see any gain in this change.

https://github.com/llvm/llvm-project/pull/181092