[llvm] [NFC][SPIRV] Remove `SPIRVType` from comments (PR #181652)
Juan Manuel Martinez CaamaƱo via llvm-commits
llvm-commits at lists.llvm.org
Mon Feb 16 06:07:30 PST 2026
https://github.com/jmmartinez updated https://github.com/llvm/llvm-project/pull/181652
>From 5ec85fdf947edf91fbd77c45e3cab810eba487b1 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Juan=20Manuel=20Martinez=20Caama=C3=B1o?=
<jmartinezcaamao at gmail.com>
Date: Mon, 16 Feb 2026 13:19:28 +0100
Subject: [PATCH] [NFC][SPIRV] Remove `SPIRVType` from comments
---
llvm/lib/Target/SPIRV/SPIRVBuiltins.cpp | 7 ++++---
llvm/lib/Target/SPIRV/SPIRVPreLegalizer.cpp | 8 ++++----
2 files changed, 8 insertions(+), 7 deletions(-)
diff --git a/llvm/lib/Target/SPIRV/SPIRVBuiltins.cpp b/llvm/lib/Target/SPIRV/SPIRVBuiltins.cpp
index 8091bdc512421..3123a6f9ffe77 100644
--- a/llvm/lib/Target/SPIRV/SPIRVBuiltins.cpp
+++ b/llvm/lib/Target/SPIRV/SPIRVBuiltins.cpp
@@ -531,8 +531,9 @@ static Register buildBuiltinVariableLoad(
return LoadedRegister;
}
-/// Helper external function for assigning SPIRVType to a register, ensuring the
-/// register class and type are set in MRI. Defined in SPIRVPreLegalizer.cpp.
+/// Helper external function for assigning a SPIRV type to a register, ensuring
+/// the register class and type are set in MRI. Defined in
+/// SPIRVPreLegalizer.cpp.
extern void updateRegType(Register Reg, Type *Ty, SPIRVTypeInst SpirvTy,
SPIRVGlobalRegistry *GR, MachineIRBuilder &MIB,
MachineRegisterInfo &MRI);
@@ -3617,7 +3618,7 @@ lowerBuiltinType(const Type *OpaqueType,
// "Lower" the BuiltinType into TargetType. The following get<...>Type
// methods use the implementation details from TableGen records or
// TargetExtType parameters to either create a new OpType<...> machine
- // instruction or get an existing equivalent SPIRVType from
+ // instruction or get an existing equivalent SPIRV type from
// GlobalRegistry.
switch (TypeRecord->Opcode) {
diff --git a/llvm/lib/Target/SPIRV/SPIRVPreLegalizer.cpp b/llvm/lib/Target/SPIRV/SPIRVPreLegalizer.cpp
index 89b6975cdbdbd..3849a8b223b36 100644
--- a/llvm/lib/Target/SPIRV/SPIRVPreLegalizer.cpp
+++ b/llvm/lib/Target/SPIRV/SPIRVPreLegalizer.cpp
@@ -195,7 +195,7 @@ static void buildOpBitcast(SPIRVGlobalRegistry *GR, MachineIRBuilder &MIB,
// We lower G_BITCAST to OpBitcast here to avoid a MachineVerifier error.
// The verifier checks if the source and destination LLTs of a G_BITCAST are
// different, but this check is too strict for SPIR-V's typed pointers, which
-// may have the same LLT but different SPIRVType (e.g. pointers to different
+// may have the same LLT but different SPIRV type (e.g. pointers to different
// pointee types). By lowering to OpBitcast here, we bypass the verifier's
// check. See discussion in https://github.com/llvm/llvm-project/pull/110270
// for more context.
@@ -295,9 +295,9 @@ static void insertBitcasts(MachineFunction &MF, SPIRVGlobalRegistry *GR,
// %1 = G_ZEXT %2
// G_MEMCPY ... %2 ...
//
-// New registers have no SPIRVType and no register class info.
+// New registers have no SPIRV type and no register class info.
//
-// Set SPIRVType for GV, propagate it from GV to other instructions,
+// Set SPIRV type for GV, propagate it from GV to other instructions,
// also set register classes.
static SPIRVTypeInst propagateSPIRVType(MachineInstr *MI,
SPIRVGlobalRegistry *GR,
@@ -628,7 +628,7 @@ generateAssignInstrs(MachineFunction &MF, SPIRVGlobalRegistry *GR,
}
// Address the case when IRTranslator introduces instructions with new
- // registers without SPIRVType associated.
+ // registers without associated SPIRV type.
for (MachineBasicBlock &MBB : MF) {
for (MachineInstr &MI : MBB) {
switch (MI.getOpcode()) {
More information about the llvm-commits
mailing list