[llvm] [NFC][AArch64] Split fptoi tests and add scal_to_vec convert tests (PR #179315)
via llvm-commits
llvm-commits at lists.llvm.org
Mon Feb 16 02:30:00 PST 2026
================
@@ -0,0 +1,49 @@
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --version 5
+; RUN: llc < %s -mtriple aarch64-unknown-unknown -mattr=+fullfp16,+fprcvt | FileCheck %s
----------------
Lukacma wrote:
I see. To me the purpose of these tests is to test new functionality added in the patch they are tied to, which I think this testfile covers. If I were to add tests here for all possible situations in which this change improves final assembly, that would be a lot of tests. I would need to add tests for all types as you mentioned for each IR node. Just from the top of my head that would mean adding tests for fptosi, fptoui, their strictfp variants, l/llround, l/llrint, aarch64 fcvt intrinsics, stores, loads which in my opinion is way too many tests to add and will still probably not cover all situations in which this change is beneficial.
https://github.com/llvm/llvm-project/pull/179315
More information about the llvm-commits
mailing list