[llvm] [SDAG] Remove useless check (PR #181538)
via llvm-commits
llvm-commits at lists.llvm.org
Sun Feb 15 01:51:51 PST 2026
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-llvm-selectiondag
Author: None (natanelh-mobileye)
<details>
<summary>Changes</summary>
At this point in the code we already know that it is legal to make that abd node.
---
Full diff: https://github.com/llvm/llvm-project/pull/181538.diff
1 Files Affected:
- (modified) llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp (+2-4)
``````````diff
diff --git a/llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp b/llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
index 65675036d1305..73bac443b07ff 100644
--- a/llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
+++ b/llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
@@ -12594,8 +12594,7 @@ SDValue DAGCombiner::foldSelectToABD(SDValue LHS, SDValue RHS, SDValue True,
if (sd_match(True, m_AnyOf(m_Sub(m_Specific(RHS), m_Specific(LHS)),
m_Add(m_Specific(RHS), m_SpecificNeg(LHS)))) &&
sd_match(False, m_AnyOf(m_Sub(m_Specific(LHS), m_Specific(RHS)),
- m_Add(m_Specific(LHS), m_SpecificNeg(RHS)))) &&
- hasOperation(ABDOpc, VT))
+ m_Add(m_Specific(LHS), m_SpecificNeg(RHS)))))
return DAG.getNegative(DAG.getNode(ABDOpc, DL, VT, LHS, RHS), DL, VT);
break;
case ISD::SETLT:
@@ -12610,8 +12609,7 @@ SDValue DAGCombiner::foldSelectToABD(SDValue LHS, SDValue RHS, SDValue True,
if (sd_match(True, m_AnyOf(m_Sub(m_Specific(LHS), m_Specific(RHS)),
m_Add(m_Specific(LHS), m_SpecificNeg(RHS)))) &&
sd_match(False, m_AnyOf(m_Sub(m_Specific(RHS), m_Specific(LHS)),
- m_Add(m_Specific(RHS), m_SpecificNeg(LHS)))) &&
- hasOperation(ABDOpc, VT))
+ m_Add(m_Specific(RHS), m_SpecificNeg(LHS)))))
return DAG.getNegative(DAG.getNode(ABDOpc, DL, VT, LHS, RHS), DL, VT);
break;
default:
``````````
</details>
https://github.com/llvm/llvm-project/pull/181538
More information about the llvm-commits
mailing list