[llvm] [NFC][SPIRV] Disable spirv-val in tests for constrained intrinsics (PR #181516)
Dmitry Sidorov via llvm-commits
llvm-commits at lists.llvm.org
Sat Feb 14 15:55:21 PST 2026
https://github.com/MrSidims created https://github.com/llvm/llvm-project/pull/181516
Currently it errors out due to FPRoundingMode misplacement.
>From 456bdde22239f9787dba52b8775b677e3046be81 Mon Sep 17 00:00:00 2001
From: Dmitry Sidorov <Dmitry.Sidorov at amd.com>
Date: Sun, 15 Feb 2026 00:53:10 +0100
Subject: [PATCH] [NFC][SPIRV] Disable spirv-val in tests for constrained
intrinsics
Currently it errors out due to FPRoundingMode misplacement.
---
.../CodeGen/SPIRV/llvm-intrinsics/constrained-arithmetic.ll | 3 ++-
llvm/test/CodeGen/SPIRV/llvm-intrinsics/constrained-fmuladd.ll | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/llvm/test/CodeGen/SPIRV/llvm-intrinsics/constrained-arithmetic.ll b/llvm/test/CodeGen/SPIRV/llvm-intrinsics/constrained-arithmetic.ll
index 14d25ae9b686e..c705a65c02b94 100644
--- a/llvm/test/CodeGen/SPIRV/llvm-intrinsics/constrained-arithmetic.ll
+++ b/llvm/test/CodeGen/SPIRV/llvm-intrinsics/constrained-arithmetic.ll
@@ -1,5 +1,6 @@
; RUN: llc -verify-machineinstrs -O0 -mtriple=spirv64-unknown-unknown %s -o - | FileCheck %s
-; RUN: %if spirv-tools %{ llc -O0 -mtriple=spirv64-unknown-unknown %s -o - -filetype=obj | spirv-val %}
+; TODO: re-enable validator FPRoundingMode is placed correctly
+; RUNx: %if spirv-tools %{ llc -O0 -mtriple=spirv64-unknown-unknown %s -o - -filetype=obj | spirv-val %}
; CHECK-DAG: %[[#r1:]] = OpFAdd %[[#]] %[[#]]
; CHECK-DAG: %[[#r2:]] = OpFDiv %[[#]] %[[#]]
diff --git a/llvm/test/CodeGen/SPIRV/llvm-intrinsics/constrained-fmuladd.ll b/llvm/test/CodeGen/SPIRV/llvm-intrinsics/constrained-fmuladd.ll
index 340f2d78fc21b..b2d4f570afbd9 100644
--- a/llvm/test/CodeGen/SPIRV/llvm-intrinsics/constrained-fmuladd.ll
+++ b/llvm/test/CodeGen/SPIRV/llvm-intrinsics/constrained-fmuladd.ll
@@ -1,5 +1,6 @@
; RUN: llc -mtriple=spirv64-unknown-unknown %s -o - | FileCheck %s
-; RUN: %if spirv-tools %{ llc -mtriple=spirv64-unknown-unknown %s -o - -filetype=obj | spirv-val %}
+; TODO: re-enable validator FPRoundingMode is placed correctly
+; RUNx: %if spirv-tools %{ llc -mtriple=spirv64-unknown-unknown %s -o - -filetype=obj | spirv-val %}
; CHECK-DAG: OpDecorate %[[#]] FPRoundingMode RTE
; CHECK-DAG: OpDecorate %[[#]] FPRoundingMode RTZ
More information about the llvm-commits
mailing list