[llvm] [LV] Support argmin/argmax with strict predicates. (PR #170223)
Florian Hahn via llvm-commits
llvm-commits at lists.llvm.org
Sat Feb 14 08:41:43 PST 2026
================
@@ -1432,7 +1433,143 @@ bool VPlanTransforms::handleFindLastReductions(VPlan &Plan) {
return true;
}
-bool VPlanTransforms::handleMultiUseReductions(VPlan &Plan) {
+/// Given a first argmin/argmax pattern with strict predicate consisting of
+/// 1) a MinOrMax reduction \p MinOrMaxPhiR producing \p MinOrMaxResult,
+/// 2) a wide induction \p WideIV,
+/// 3) a FindLastIV reduction \p FindLastIVPhiR,
+/// return the smallest index of the FindLastIV reduction result using UMin,
+/// unless \p MinOrMaxResult equals the start value of its MinOrMax reduction.
+/// In that case, return the start value of the FindLastIV reduction instead.
+/// If \p WideIV is not canonical, a new canonical wide IV is added, and the
+/// final result is scaled back to the non-canonical \p WideIV.
+/// The final value of the FindLastIV reduction was originally computed using
+/// \p FindIVSelect, \p FindIVCmp, and \p FindIVRdxResult, which are replaced
+/// and removed.
+/// Returns true if the pattern was handled successfully, false otherwise.
+static bool handleFirstArgMinOrMax(
+ VPlan &Plan, VPReductionPHIRecipe *MinOrMaxPhiR,
+ VPReductionPHIRecipe *FindLastIVPhiR, VPWidenIntOrFpInductionRecipe *WideIV,
+ VPInstruction *MinOrMaxResult, VPInstruction *FindIVSelect,
+ VPRecipeBase *FindIVCmp, VPInstruction *FindIVRdxResult) {
+ Type *Ty = Plan.getVectorLoopRegion()->getCanonicalIVType();
+ // TODO: Support non (i.e., narrower than) canonical IV types.
+ if (Ty != VPTypeAnalysis(Plan).inferScalarType(WideIV))
+ return false;
+
+ auto *FindIVSelectR = cast<VPSingleDefRecipe>(
+ FindLastIVPhiR->getBackedgeValue()->getDefiningRecipe());
+ assert(
+ match(FindIVSelectR, m_Select(m_VPValue(), m_VPValue(), m_VPValue())) &&
+ "backedge value must be a select");
+ if (FindIVSelectR->getOperand(1) != WideIV &&
+ FindIVSelectR->getOperand(2) != WideIV)
+ return false;
----------------
fhahn wrote:
Updated the comment; currently this check is needed, because we may have other variants we do not yet support, like truncated WideIV etc.
https://github.com/llvm/llvm-project/pull/170223
More information about the llvm-commits
mailing list