[llvm] [TableGen] Introduce MatcherList to manage a linked list of Matchers. NFC (PR #177875)

Fri Feb 13 18:01:12 PST 2026

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `amdgpu-offload-rhel-9-cmake-build-only` running on `rocm-docker-rhel-9` while building `llvm` at step 4 "annotate".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/205/builds/36165

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 4 (annotate) failure: '../llvm-zorg/zorg/buildbot/builders/annotated/amdgpu-offload-cmake.py --jobs=32' (failure)
...
[4421/8488] Building X86GenRegisterInfo.inc...
[4422/8488] Building CXX object tools/mlir/lib/Dialect/AMDGPU/IR/CMakeFiles/obj.MLIRAMDGPUDialect.dir/AMDGPUDialect.cpp.o
[4423/8488] Building CXX object tools/mlir/lib/Dialect/AMDGPU/IR/CMakeFiles/obj.MLIRAMDGPUDialect.dir/AMDGPUAttrs.cpp.o
[4424/8488] Building CXX object tools/mlir/lib/Dialect/Affine/Utils/CMakeFiles/obj.MLIRAffineUtils.dir/LoopUtils.cpp.o
[4425/8488] Building CXX object tools/mlir/lib/Dialect/AMDGPU/IR/CMakeFiles/obj.MLIRAMDGPUDialect.dir/AMDGPUTypes.cpp.o
[4426/8488] Building CXX object tools/mlir/lib/Dialect/Affine/Utils/CMakeFiles/obj.MLIRAffineUtils.dir/Utils.cpp.o
[4427/8488] Building CXX object tools/mlir/lib/Dialect/Affine/TransformOps/CMakeFiles/obj.MLIRAffineTransformOps.dir/AffineTransformOps.cpp.o
[4428/8488] Building CXX object tools/mlir/lib/Dialect/AMDGPU/Transforms/CMakeFiles/obj.MLIRAMDGPUTransforms.dir/EmulateAtomics.cpp.o
[4429/8488] Building CXX object tools/mlir/lib/Dialect/AMDGPU/Transforms/CMakeFiles/obj.MLIRAMDGPUTransforms.dir/FoldMemRefsOps.cpp.o
[4430/8488] Building X86GenDAGISel.inc...
FAILED: lib/Target/X86/X86GenDAGISel.inc /home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/build/lib/Target/X86/X86GenDAGISel.inc 
cd /home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/build/lib/Target/X86 && /home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/build/bin/llvm-tblgen -gen-dag-isel -I/home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/llvm-project/llvm/lib/Target/X86 -I/home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/build/include -I/home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/llvm-project/llvm/include -I /home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/llvm-project/llvm/lib/Target -omit-comments /home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/llvm-project/llvm/lib/Target/X86/X86.td --write-if-changed -o X86GenDAGISel.inc -d X86GenDAGISel.inc.d && /usr/bin/cmake -E cmake_transform_depfile Ninja gccdepfile /home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/llvm-project/llvm /home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/llvm-project/llvm/lib/Target/X86 /home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/build /home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/build/lib/Target/X86 /home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/build/lib/Target/X86/X86GenDAGISel.inc.d /home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/build/CMakeFiles/d/863e7a66728cb6bf765fa478fe37a402e92cbec82e48c26e779a72ed072365c6.d
llvm-tblgen: /home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/llvm-project/llvm/utils/TableGen/DAGISelMatcherOpt.cpp:486: void FactorScope(llvm::MatcherList&, llvm::MatcherList::iterator): Assertion `!Optn == !Tmp && "Expected all to be null if any are null"' failed.
PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace and instructions to reproduce the bug.
Stack dump:
0.	Program arguments: /home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/build/bin/llvm-tblgen -gen-dag-isel -I/home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/llvm-project/llvm/lib/Target/X86 -I/home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/build/include -I/home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/llvm-project/llvm/include -I /home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/llvm-project/llvm/lib/Target -omit-comments /home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/llvm-project/llvm/lib/Target/X86/X86.td --write-if-changed -o X86GenDAGISel.inc -d X86GenDAGISel.inc.d
 #0 0x00007080f5201bb1 llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) (/home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/build/bin/../lib/libLLVMSupport.so.23.0git+0x201bb1)
 #1 0x00007080f51fea9b llvm::sys::RunSignalHandlers() (/home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/build/bin/../lib/libLLVMSupport.so.23.0git+0x1fea9b)
 #2 0x00007080f51febc6 SignalHandler(int, siginfo_t*, void*) Signals.cpp:0:0
 #3 0x00007080f4c0d730 __restore_rt (/lib64/libc.so.6+0x3e730)
 #4 0x00007080f4c5aa6c __pthread_kill_implementation (/lib64/libc.so.6+0x8ba6c)
 #5 0x00007080f4c0d686 gsignal (/lib64/libc.so.6+0x3e686)
 #6 0x00007080f4bf7833 abort (/lib64/libc.so.6+0x28833)
 #7 0x00007080f4bf775b _nl_load_domain.cold (/lib64/libc.so.6+0x2875b)
 #8 0x00007080f4c063c6 (/lib64/libc.so.6+0x373c6)
 #9 0x00000000005fff0a FactorScope(llvm::MatcherList&, llvm::MatcherList::iterator_impl<false>) DAGISelMatcherOpt.cpp:0:0
#10 0x00000000005ff147 FactorScope(llvm::MatcherList&, llvm::MatcherList::iterator_impl<false>) DAGISelMatcherOpt.cpp:0:0
#11 0x00000000005ff147 FactorScope(llvm::MatcherList&, llvm::MatcherList::iterator_impl<false>) DAGISelMatcherOpt.cpp:0:0
#12 0x00000000005ff147 FactorScope(llvm::MatcherList&, llvm::MatcherList::iterator_impl<false>) DAGISelMatcherOpt.cpp:0:0
#13 0x00000000005ff147 FactorScope(llvm::MatcherList&, llvm::MatcherList::iterator_impl<false>) DAGISelMatcherOpt.cpp:0:0
#14 0x00000000005ff147 FactorScope(llvm::MatcherList&, llvm::MatcherList::iterator_impl<false>) DAGISelMatcherOpt.cpp:0:0
#15 0x00000000005ff147 FactorScope(llvm::MatcherList&, llvm::MatcherList::iterator_impl<false>) DAGISelMatcherOpt.cpp:0:0
#16 0x00000000005ff147 FactorScope(llvm::MatcherList&, llvm::MatcherList::iterator_impl<false>) DAGISelMatcherOpt.cpp:0:0
#17 0x00000000005ff147 FactorScope(llvm::MatcherList&, llvm::MatcherList::iterator_impl<false>) DAGISelMatcherOpt.cpp:0:0
#18 0x00000000005ff147 FactorScope(llvm::MatcherList&, llvm::MatcherList::iterator_impl<false>) DAGISelMatcherOpt.cpp:0:0
#19 0x00000000005ff147 FactorScope(llvm::MatcherList&, llvm::MatcherList::iterator_impl<false>) DAGISelMatcherOpt.cpp:0:0
#20 0x00000000005ff147 FactorScope(llvm::MatcherList&, llvm::MatcherList::iterator_impl<false>) DAGISelMatcherOpt.cpp:0:0
#21 0x00000000005ff147 FactorScope(llvm::MatcherList&, llvm::MatcherList::iterator_impl<false>) DAGISelMatcherOpt.cpp:0:0
#22 0x00000000005ff147 FactorScope(llvm::MatcherList&, llvm::MatcherList::iterator_impl<false>) DAGISelMatcherOpt.cpp:0:0
#23 0x00000000005ff147 FactorScope(llvm::MatcherList&, llvm::MatcherList::iterator_impl<false>) DAGISelMatcherOpt.cpp:0:0
#24 0x00000000005ff147 FactorScope(llvm::MatcherList&, llvm::MatcherList::iterator_impl<false>) DAGISelMatcherOpt.cpp:0:0
#25 0x00000000005ff147 FactorScope(llvm::MatcherList&, llvm::MatcherList::iterator_impl<false>) DAGISelMatcherOpt.cpp:0:0
#26 0x00000000005ff147 FactorScope(llvm::MatcherList&, llvm::MatcherList::iterator_impl<false>) DAGISelMatcherOpt.cpp:0:0
#27 0x00000000005ff147 FactorScope(llvm::MatcherList&, llvm::MatcherList::iterator_impl<false>) DAGISelMatcherOpt.cpp:0:0
#28 0x00000000005ff147 FactorScope(llvm::MatcherList&, llvm::MatcherList::iterator_impl<false>) DAGISelMatcherOpt.cpp:0:0
#29 0x00000000005ff147 FactorScope(llvm::MatcherList&, llvm::MatcherList::iterator_impl<false>) DAGISelMatcherOpt.cpp:0:0
#30 0x00000000005ff147 FactorScope(llvm::MatcherList&, llvm::MatcherList::iterator_impl<false>) DAGISelMatcherOpt.cpp:0:0
#31 0x00000000005ff147 FactorScope(llvm::MatcherList&, llvm::MatcherList::iterator_impl<false>) DAGISelMatcherOpt.cpp:0:0
#32 0x00000000005d7b86 llvm::TableGen::Emitter::OptClass<(anonymous namespace)::DAGISelEmitter>::run(llvm::StringRef, llvm::RecordKeeper const&) DAGISelEmitter.cpp:0:0
Step 7 (build cmake config) failure: build cmake config (failure)
...
[4421/8488] Building X86GenRegisterInfo.inc...
[4422/8488] Building CXX object tools/mlir/lib/Dialect/AMDGPU/IR/CMakeFiles/obj.MLIRAMDGPUDialect.dir/AMDGPUDialect.cpp.o
[4423/8488] Building CXX object tools/mlir/lib/Dialect/AMDGPU/IR/CMakeFiles/obj.MLIRAMDGPUDialect.dir/AMDGPUAttrs.cpp.o
[4424/8488] Building CXX object tools/mlir/lib/Dialect/Affine/Utils/CMakeFiles/obj.MLIRAffineUtils.dir/LoopUtils.cpp.o
[4425/8488] Building CXX object tools/mlir/lib/Dialect/AMDGPU/IR/CMakeFiles/obj.MLIRAMDGPUDialect.dir/AMDGPUTypes.cpp.o
[4426/8488] Building CXX object tools/mlir/lib/Dialect/Affine/Utils/CMakeFiles/obj.MLIRAffineUtils.dir/Utils.cpp.o
[4427/8488] Building CXX object tools/mlir/lib/Dialect/Affine/TransformOps/CMakeFiles/obj.MLIRAffineTransformOps.dir/AffineTransformOps.cpp.o
[4428/8488] Building CXX object tools/mlir/lib/Dialect/AMDGPU/Transforms/CMakeFiles/obj.MLIRAMDGPUTransforms.dir/EmulateAtomics.cpp.o
[4429/8488] Building CXX object tools/mlir/lib/Dialect/AMDGPU/Transforms/CMakeFiles/obj.MLIRAMDGPUTransforms.dir/FoldMemRefsOps.cpp.o
[4430/8488] Building X86GenDAGISel.inc...
FAILED: lib/Target/X86/X86GenDAGISel.inc /home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/build/lib/Target/X86/X86GenDAGISel.inc 
cd /home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/build/lib/Target/X86 && /home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/build/bin/llvm-tblgen -gen-dag-isel -I/home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/llvm-project/llvm/lib/Target/X86 -I/home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/build/include -I/home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/llvm-project/llvm/include -I /home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/llvm-project/llvm/lib/Target -omit-comments /home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/llvm-project/llvm/lib/Target/X86/X86.td --write-if-changed -o X86GenDAGISel.inc -d X86GenDAGISel.inc.d && /usr/bin/cmake -E cmake_transform_depfile Ninja gccdepfile /home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/llvm-project/llvm /home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/llvm-project/llvm/lib/Target/X86 /home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/build /home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/build/lib/Target/X86 /home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/build/lib/Target/X86/X86GenDAGISel.inc.d /home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/build/CMakeFiles/d/863e7a66728cb6bf765fa478fe37a402e92cbec82e48c26e779a72ed072365c6.d
llvm-tblgen: /home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/llvm-project/llvm/utils/TableGen/DAGISelMatcherOpt.cpp:486: void FactorScope(llvm::MatcherList&, llvm::MatcherList::iterator): Assertion `!Optn == !Tmp && "Expected all to be null if any are null"' failed.
PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace and instructions to reproduce the bug.
Stack dump:
0.	Program arguments: /home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/build/bin/llvm-tblgen -gen-dag-isel -I/home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/llvm-project/llvm/lib/Target/X86 -I/home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/build/include -I/home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/llvm-project/llvm/include -I /home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/llvm-project/llvm/lib/Target -omit-comments /home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/llvm-project/llvm/lib/Target/X86/X86.td --write-if-changed -o X86GenDAGISel.inc -d X86GenDAGISel.inc.d
 #0 0x00007080f5201bb1 llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) (/home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/build/bin/../lib/libLLVMSupport.so.23.0git+0x201bb1)
 #1 0x00007080f51fea9b llvm::sys::RunSignalHandlers() (/home/botworker/bbot/amdgpu-offload-rhel-9-cmake-build-only/build/bin/../lib/libLLVMSupport.so.23.0git+0x1fea9b)
 #2 0x00007080f51febc6 SignalHandler(int, siginfo_t*, void*) Signals.cpp:0:0
 #3 0x00007080f4c0d730 __restore_rt (/lib64/libc.so.6+0x3e730)
 #4 0x00007080f4c5aa6c __pthread_kill_implementation (/lib64/libc.so.6+0x8ba6c)
 #5 0x00007080f4c0d686 gsignal (/lib64/libc.so.6+0x3e686)
 #6 0x00007080f4bf7833 abort (/lib64/libc.so.6+0x28833)
 #7 0x00007080f4bf775b _nl_load_domain.cold (/lib64/libc.so.6+0x2875b)
 #8 0x00007080f4c063c6 (/lib64/libc.so.6+0x373c6)
 #9 0x00000000005fff0a FactorScope(llvm::MatcherList&, llvm::MatcherList::iterator_impl<false>) DAGISelMatcherOpt.cpp:0:0
#10 0x00000000005ff147 FactorScope(llvm::MatcherList&, llvm::MatcherList::iterator_impl<false>) DAGISelMatcherOpt.cpp:0:0
#11 0x00000000005ff147 FactorScope(llvm::MatcherList&, llvm::MatcherList::iterator_impl<false>) DAGISelMatcherOpt.cpp:0:0
#12 0x00000000005ff147 FactorScope(llvm::MatcherList&, llvm::MatcherList::iterator_impl<false>) DAGISelMatcherOpt.cpp:0:0
#13 0x00000000005ff147 FactorScope(llvm::MatcherList&, llvm::MatcherList::iterator_impl<false>) DAGISelMatcherOpt.cpp:0:0
#14 0x00000000005ff147 FactorScope(llvm::MatcherList&, llvm::MatcherList::iterator_impl<false>) DAGISelMatcherOpt.cpp:0:0
#15 0x00000000005ff147 FactorScope(llvm::MatcherList&, llvm::MatcherList::iterator_impl<false>) DAGISelMatcherOpt.cpp:0:0
#16 0x00000000005ff147 FactorScope(llvm::MatcherList&, llvm::MatcherList::iterator_impl<false>) DAGISelMatcherOpt.cpp:0:0
#17 0x00000000005ff147 FactorScope(llvm::MatcherList&, llvm::MatcherList::iterator_impl<false>) DAGISelMatcherOpt.cpp:0:0
#18 0x00000000005ff147 FactorScope(llvm::MatcherList&, llvm::MatcherList::iterator_impl<false>) DAGISelMatcherOpt.cpp:0:0
#19 0x00000000005ff147 FactorScope(llvm::MatcherList&, llvm::MatcherList::iterator_impl<false>) DAGISelMatcherOpt.cpp:0:0
#20 0x00000000005ff147 FactorScope(llvm::MatcherList&, llvm::MatcherList::iterator_impl<false>) DAGISelMatcherOpt.cpp:0:0
#21 0x00000000005ff147 FactorScope(llvm::MatcherList&, llvm::MatcherList::iterator_impl<false>) DAGISelMatcherOpt.cpp:0:0
#22 0x00000000005ff147 FactorScope(llvm::MatcherList&, llvm::MatcherList::iterator_impl<false>) DAGISelMatcherOpt.cpp:0:0
#23 0x00000000005ff147 FactorScope(llvm::MatcherList&, llvm::MatcherList::iterator_impl<false>) DAGISelMatcherOpt.cpp:0:0
#24 0x00000000005ff147 FactorScope(llvm::MatcherList&, llvm::MatcherList::iterator_impl<false>) DAGISelMatcherOpt.cpp:0:0
#25 0x00000000005ff147 FactorScope(llvm::MatcherList&, llvm::MatcherList::iterator_impl<false>) DAGISelMatcherOpt.cpp:0:0
#26 0x00000000005ff147 FactorScope(llvm::MatcherList&, llvm::MatcherList::iterator_impl<false>) DAGISelMatcherOpt.cpp:0:0
#27 0x00000000005ff147 FactorScope(llvm::MatcherList&, llvm::MatcherList::iterator_impl<false>) DAGISelMatcherOpt.cpp:0:0
#28 0x00000000005ff147 FactorScope(llvm::MatcherList&, llvm::MatcherList::iterator_impl<false>) DAGISelMatcherOpt.cpp:0:0
#29 0x00000000005ff147 FactorScope(llvm::MatcherList&, llvm::MatcherList::iterator_impl<false>) DAGISelMatcherOpt.cpp:0:0
#30 0x00000000005ff147 FactorScope(llvm::MatcherList&, llvm::MatcherList::iterator_impl<false>) DAGISelMatcherOpt.cpp:0:0
#31 0x00000000005ff147 FactorScope(llvm::MatcherList&, llvm::MatcherList::iterator_impl<false>) DAGISelMatcherOpt.cpp:0:0
#32 0x00000000005d7b86 llvm::TableGen::Emitter::OptClass<(anonymous namespace)::DAGISelEmitter>::run(llvm::StringRef, llvm::RecordKeeper const&) DAGISelEmitter.cpp:0:0

```

</details>

https://github.com/llvm/llvm-project/pull/177875