[llvm] [DAGCombiner] Fix crash caused by illegal InterVT in ForwardStoreValueToDirectLoad (PR #181175)

via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 13 03:39:58 PST 2026


https://github.com/Michael-Chen-NJU updated https://github.com/llvm/llvm-project/pull/181175

>From 282956a57cbd16a7821d8c4bc6f81525a5d55aad Mon Sep 17 00:00:00 2001
From: Michael-Chen-NJU <2802328816 at qq.com>
Date: Fri, 13 Feb 2026 00:26:32 +0800
Subject: [PATCH 1/2] [DAGCombine] Fix crash caused by illegal InterVT in
 ForwardStoreValueToDirectLoad

---
 llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp |  3 ++-
 .../CodeGen/X86/stlf-v32i1-bitcast-crash.ll   | 21 +++++++++++++++++++
 2 files changed, 23 insertions(+), 1 deletion(-)
 create mode 100644 llvm/test/CodeGen/X86/stlf-v32i1-bitcast-crash.ll

diff --git a/llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp b/llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
index 19bcdeeefb143..e513a16ee0e27 100644
--- a/llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
+++ b/llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
@@ -20831,7 +20831,8 @@ SDValue DAGCombiner::ForwardStoreValueToDirectLoad(LoadSDNode *LD) {
 
         EVT InterVT = EVT::getVectorVT(*DAG.getContext(), EltVT,
                                        StMemSize.divideCoefficientBy(EltSize));
-        if (!TLI.isOperationLegalOrCustom(ISD::EXTRACT_SUBVECTOR, LDMemType))
+        if (!TLI.isOperationLegalOrCustom(ISD::EXTRACT_SUBVECTOR, LDMemType) ||
+            !TLI.isTypeLegal(InterVT))
           break;
 
         // In case of big-endian the offset is normalized to zero, denoting
diff --git a/llvm/test/CodeGen/X86/stlf-v32i1-bitcast-crash.ll b/llvm/test/CodeGen/X86/stlf-v32i1-bitcast-crash.ll
new file mode 100644
index 0000000000000..2abdc547dd479
--- /dev/null
+++ b/llvm/test/CodeGen/X86/stlf-v32i1-bitcast-crash.ll
@@ -0,0 +1,21 @@
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --version 6
+; RUN: llc < %s -mtriple=x86_64-pc-windows-gnu -mcpu=tigerlake | FileCheck %s
+
+define <32 x i1> @v32i1_bitcast_crash(<4 x i8> %0) {
+; CHECK-LABEL: v32i1_bitcast_crash:
+; CHECK:       # %bb.0:
+; CHECK-NEXT:    subq $24, %rsp
+; CHECK-NEXT:    .seh_stackalloc 24
+; CHECK-NEXT:    .seh_endprologue
+; CHECK-NEXT:    vmovaps (%rcx), %xmm0
+; CHECK-NEXT:    vmovaps %xmm0, (%rsp)
+; CHECK-NEXT:    kmovd (%rsp), %k0
+; CHECK-NEXT:    vpmovm2b %k0, %ymm0
+; CHECK-NEXT:    .seh_startepilogue
+; CHECK-NEXT:    addq $24, %rsp
+; CHECK-NEXT:    .seh_endepilogue
+; CHECK-NEXT:    retq
+; CHECK-NEXT:    .seh_endproc
+  %2 = bitcast <4 x i8> %0 to <32 x i1>
+  ret <32 x i1> %2
+}

>From 78349b3a63489d38c61e4017817c5ce583645049 Mon Sep 17 00:00:00 2001
From: Michael-Chen-NJU <2802328816 at qq.com>
Date: Wed, 11 Feb 2026 01:37:11 +0800
Subject: [PATCH 2/2] [DAGCombiner] Fix subvector extraction index for
 big-endian STLF

---
 llvm/test/CodeGen/X86/dag-stlf-mismatch.ll    | 16 +++++++++++++-
 .../CodeGen/X86/stlf-v32i1-bitcast-crash.ll   | 21 -------------------
 2 files changed, 15 insertions(+), 22 deletions(-)
 delete mode 100644 llvm/test/CodeGen/X86/stlf-v32i1-bitcast-crash.ll

diff --git a/llvm/test/CodeGen/X86/dag-stlf-mismatch.ll b/llvm/test/CodeGen/X86/dag-stlf-mismatch.ll
index a1ee713b32032..5c46b7a8dbdc4 100644
--- a/llvm/test/CodeGen/X86/dag-stlf-mismatch.ll
+++ b/llvm/test/CodeGen/X86/dag-stlf-mismatch.ll
@@ -1,5 +1,5 @@
-; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --version 6
 ; RUN: llc < %s -mtriple=x86_64-- | FileCheck %s
+; RUN: llc < %s -mtriple=x86_64-pc-windows-gnu -mcpu=tigerlake | FileCheck %s --check-prefix=TIGER
 
 %struct.Data = type { float }
 
@@ -69,3 +69,17 @@ define float @test_stlf_variable(ptr %p, i32 %val, float %v) {
   %r = fmul float %f, %v
   ret float %r
 }
+
+define <32 x i1> @v32i1_bitcast_crash(<4 x i8> %arg) nounwind {
+; TIGER-LABEL: v32i1_bitcast_crash:
+; TIGER:       # %bb.0:
+; TIGER-NEXT:    subq $24, %rsp
+; TIGER-NEXT:    vmovaps (%rcx), %xmm0
+; TIGER-NEXT:    vmovaps %xmm0, (%rsp)
+; TIGER-NEXT:    kmovd (%rsp), %k0
+; TIGER-NEXT:    vpmovm2b %k0, %ymm0
+; TIGER-NEXT:    addq $24, %rsp
+; TIGER-NEXT:    retq
+  %res = bitcast <4 x i8> %arg to <32 x i1>
+  ret <32 x i1> %res
+}
diff --git a/llvm/test/CodeGen/X86/stlf-v32i1-bitcast-crash.ll b/llvm/test/CodeGen/X86/stlf-v32i1-bitcast-crash.ll
deleted file mode 100644
index 2abdc547dd479..0000000000000
--- a/llvm/test/CodeGen/X86/stlf-v32i1-bitcast-crash.ll
+++ /dev/null
@@ -1,21 +0,0 @@
-; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --version 6
-; RUN: llc < %s -mtriple=x86_64-pc-windows-gnu -mcpu=tigerlake | FileCheck %s
-
-define <32 x i1> @v32i1_bitcast_crash(<4 x i8> %0) {
-; CHECK-LABEL: v32i1_bitcast_crash:
-; CHECK:       # %bb.0:
-; CHECK-NEXT:    subq $24, %rsp
-; CHECK-NEXT:    .seh_stackalloc 24
-; CHECK-NEXT:    .seh_endprologue
-; CHECK-NEXT:    vmovaps (%rcx), %xmm0
-; CHECK-NEXT:    vmovaps %xmm0, (%rsp)
-; CHECK-NEXT:    kmovd (%rsp), %k0
-; CHECK-NEXT:    vpmovm2b %k0, %ymm0
-; CHECK-NEXT:    .seh_startepilogue
-; CHECK-NEXT:    addq $24, %rsp
-; CHECK-NEXT:    .seh_endepilogue
-; CHECK-NEXT:    retq
-; CHECK-NEXT:    .seh_endproc
-  %2 = bitcast <4 x i8> %0 to <32 x i1>
-  ret <32 x i1> %2
-}



More information about the llvm-commits mailing list