[llvm] [mlir] fix #176920 Add SideEffectInterfaces to dependencies (PR #181286)

Lance Wang via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 12 19:53:13 PST 2026


https://github.com/wang2yn84 updated https://github.com/llvm/llvm-project/pull/181286

>From 9d17bcb5e35cce530019ab004b4b9e6f0701d143 Mon Sep 17 00:00:00 2001
From: Lance Wang <lancewang at google.com>
Date: Thu, 12 Feb 2026 17:31:26 -0800
Subject: [PATCH 1/6] [mlir] fix ##176920 Add SideEffectInterfaces to
 dependencies

---
 utils/bazel/llvm-project-overlay/mlir/BUILD.bazel | 1 +
 1 file changed, 1 insertion(+)

diff --git a/utils/bazel/llvm-project-overlay/mlir/BUILD.bazel b/utils/bazel/llvm-project-overlay/mlir/BUILD.bazel
index c9224ef489ce9..d1bbf9eef13a8 100644
--- a/utils/bazel/llvm-project-overlay/mlir/BUILD.bazel
+++ b/utils/bazel/llvm-project-overlay/mlir/BUILD.bazel
@@ -531,6 +531,7 @@ mlir_c_api_cc_library(
         ":config",
         ":FuncTransformsPassIncGen",
         ":Rewrite",
+        ":SideEffectInterfaces",
         "//llvm:Support",
     ],
     includes = ["include"],

>From d06c50874842ac471dbc56c7d4addd1dd56663eb Mon Sep 17 00:00:00 2001
From: Lance Wang <lancewang at google.com>
Date: Thu, 12 Feb 2026 17:51:56 -0800
Subject: [PATCH 2/6] Move SideEffectInterfaces dependency to dependency from
 header dependency

---
 utils/bazel/llvm-project-overlay/mlir/BUILD.bazel | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/utils/bazel/llvm-project-overlay/mlir/BUILD.bazel b/utils/bazel/llvm-project-overlay/mlir/BUILD.bazel
index d1bbf9eef13a8..36172a4dc9cce 100644
--- a/utils/bazel/llvm-project-overlay/mlir/BUILD.bazel
+++ b/utils/bazel/llvm-project-overlay/mlir/BUILD.bazel
@@ -531,7 +531,6 @@ mlir_c_api_cc_library(
         ":config",
         ":FuncTransformsPassIncGen",
         ":Rewrite",
-        ":SideEffectInterfaces",
         "//llvm:Support",
     ],
     includes = ["include"],
@@ -542,6 +541,7 @@ mlir_c_api_cc_library(
         ":IRDLDialect",
         ":InferTypeOpInterface",
         ":Parser",
+        ":SideEffectInterfaces",
         ":TransformsPassIncGen",
     ],
 )

>From c1c8501fb70459cf97f65f33b009856f09ff42c4 Mon Sep 17 00:00:00 2001
From: Lance Wang <lancewang at google.com>
Date: Thu, 12 Feb 2026 18:03:06 -0800
Subject: [PATCH 3/6] Add SideEffectInterfaces to both deps and header_deps

---
 utils/bazel/llvm-project-overlay/mlir/BUILD.bazel | 1 +
 1 file changed, 1 insertion(+)

diff --git a/utils/bazel/llvm-project-overlay/mlir/BUILD.bazel b/utils/bazel/llvm-project-overlay/mlir/BUILD.bazel
index 36172a4dc9cce..39b52c5b3c1b8 100644
--- a/utils/bazel/llvm-project-overlay/mlir/BUILD.bazel
+++ b/utils/bazel/llvm-project-overlay/mlir/BUILD.bazel
@@ -531,6 +531,7 @@ mlir_c_api_cc_library(
         ":config",
         ":FuncTransformsPassIncGen",
         ":Rewrite",
+        ":SideEffectInterfaces",
         "//llvm:Support",
     ],
     includes = ["include"],

>From 550ab117a070ab319c0fc79abc0ce411d6e8352e Mon Sep 17 00:00:00 2001
From: Lance Wang <lancewang at google.com>
Date: Thu, 12 Feb 2026 18:49:10 -0800
Subject: [PATCH 4/6] Update CAPITransformDialect library dependencies

---
 .../bazel/llvm-project-overlay/mlir/BUILD.bazel  | 16 ++++++++++++----
 1 file changed, 12 insertions(+), 4 deletions(-)

diff --git a/utils/bazel/llvm-project-overlay/mlir/BUILD.bazel b/utils/bazel/llvm-project-overlay/mlir/BUILD.bazel
index 39b52c5b3c1b8..c265000334721 100644
--- a/utils/bazel/llvm-project-overlay/mlir/BUILD.bazel
+++ b/utils/bazel/llvm-project-overlay/mlir/BUILD.bazel
@@ -542,7 +542,6 @@ mlir_c_api_cc_library(
         ":IRDLDialect",
         ":InferTypeOpInterface",
         ":Parser",
-        ":SideEffectInterfaces",
         ":TransformsPassIncGen",
     ],
 )
@@ -856,11 +855,20 @@ mlir_c_api_cc_library(
 mlir_c_api_cc_library(
     name = "CAPITransformDialect",
     srcs = ["lib/CAPI/Dialect/Transform.cpp"],
-    hdrs = ["include/mlir-c/Dialect/Transform.h"],
+    hdrs = [
+        "include/mlir-c/Dialect/Transform.h",
+        "include/mlir/CAPI/Dialect/Transform.h",
+    ],
     capi_deps = [":CAPIIR"],
-    header_deps = [":TransformDialectTransformsIncGen"],
+    header_deps = [
+        ":TransformDialectTransformsIncGen",
+        ":TransformDialectInterfaces",
+    ],
     includes = ["include"],
-    deps = [":TransformDialect"],
+    deps = [
+        ":TransformDialect",
+        "//llvm:Support",
+    ],
 )
 
 mlir_c_api_cc_library(

>From b0e8010af9eb488d5d45b1b7d0b5b3f7f3ce0873 Mon Sep 17 00:00:00 2001
From: Lance Wang <lancewang at google.com>
Date: Thu, 12 Feb 2026 19:45:38 -0800
Subject: [PATCH 5/6] Reorder header_deps and add includes to library

---
 utils/bazel/llvm-project-overlay/mlir/BUILD.bazel | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/utils/bazel/llvm-project-overlay/mlir/BUILD.bazel b/utils/bazel/llvm-project-overlay/mlir/BUILD.bazel
index c265000334721..36b67ff8c15fb 100644
--- a/utils/bazel/llvm-project-overlay/mlir/BUILD.bazel
+++ b/utils/bazel/llvm-project-overlay/mlir/BUILD.bazel
@@ -861,8 +861,8 @@ mlir_c_api_cc_library(
     ],
     capi_deps = [":CAPIIR"],
     header_deps = [
-        ":TransformDialectTransformsIncGen",
         ":TransformDialectInterfaces",
+        ":TransformDialectTransformsIncGen",
     ],
     includes = ["include"],
     deps = [
@@ -12193,6 +12193,7 @@ cc_library(
     name = "TransformDialectInterfaces",
     srcs = glob(["lib/Dialect/Transform/Interfaces/*.cpp"]),
     hdrs = glob(["include/mlir/Dialect/Transform/Interfaces/*.h"]),
+    includes = ["include"],
     deps = [
         ":CastInterfaces",
         ":IR",

>From 0402279c6fd060a260c2b2ad827e9987beb6a423 Mon Sep 17 00:00:00 2001
From: Lance Wang <lancewang at google.com>
Date: Thu, 12 Feb 2026 19:53:02 -0800
Subject: [PATCH 6/6] Add include path for TransformDialect library

---
 utils/bazel/llvm-project-overlay/mlir/BUILD.bazel | 1 +
 1 file changed, 1 insertion(+)

diff --git a/utils/bazel/llvm-project-overlay/mlir/BUILD.bazel b/utils/bazel/llvm-project-overlay/mlir/BUILD.bazel
index 36b67ff8c15fb..620228042dded 100644
--- a/utils/bazel/llvm-project-overlay/mlir/BUILD.bazel
+++ b/utils/bazel/llvm-project-overlay/mlir/BUILD.bazel
@@ -12213,6 +12213,7 @@ cc_library(
     name = "TransformDialect",
     srcs = glob(["lib/Dialect/Transform/IR/*.cpp"]),
     hdrs = glob(["include/mlir/Dialect/Transform/IR/*.h"]),
+    includes = ["include"],
     deps = [
         ":Analysis",
         ":BytecodeOpInterface",



More information about the llvm-commits mailing list