[llvm] [NFC][AMDGPU] Remove unused/unimplemented `getWavesPerEU` variants (PR #181131)
via llvm-commits
llvm-commits at lists.llvm.org
Thu Feb 12 04:37:23 PST 2026
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-backend-amdgpu
Author: Juan Manuel Martinez CaamaƱo (jmmartinez)
<details>
<summary>Changes</summary>
I couldn't find any obvious use for these 2 variants of `getWavesPerEU`.
---
Full diff: https://github.com/llvm/llvm-project/pull/181131.diff
2 Files Affected:
- (modified) llvm/lib/Target/AMDGPU/AMDGPUAttributor.cpp (-10)
- (modified) llvm/lib/Target/AMDGPU/AMDGPUSubtarget.h (-7)
``````````diff
diff --git a/llvm/lib/Target/AMDGPU/AMDGPUAttributor.cpp b/llvm/lib/Target/AMDGPU/AMDGPUAttributor.cpp
index 4bcaabfd3263a..9bd8e97619ce1 100644
--- a/llvm/lib/Target/AMDGPU/AMDGPUAttributor.cpp
+++ b/llvm/lib/Target/AMDGPU/AMDGPUAttributor.cpp
@@ -201,16 +201,6 @@ class AMDGPUInformationCache : public InformationCache {
/// Get code object version.
unsigned getCodeObjectVersion() const { return CodeObjectVersion; }
- /// Get the effective value of "amdgpu-waves-per-eu" for the function,
- /// accounting for the interaction with the passed value to use for
- /// "amdgpu-flat-work-group-size".
- std::pair<unsigned, unsigned>
- getWavesPerEU(const Function &F,
- std::pair<unsigned, unsigned> FlatWorkGroupSize) {
- const GCNSubtarget &ST = TM.getSubtarget<GCNSubtarget>(F);
- return ST.getWavesPerEU(FlatWorkGroupSize, getLDSSize(F), F);
- }
-
std::optional<std::pair<unsigned, unsigned>>
getWavesPerEUAttr(const Function &F) {
auto Val = AMDGPU::getIntegerPairAttribute(F, "amdgpu-waves-per-eu",
diff --git a/llvm/lib/Target/AMDGPU/AMDGPUSubtarget.h b/llvm/lib/Target/AMDGPU/AMDGPUSubtarget.h
index e5dc48b6998e4..302fe7c850b75 100644
--- a/llvm/lib/Target/AMDGPU/AMDGPUSubtarget.h
+++ b/llvm/lib/Target/AMDGPU/AMDGPUSubtarget.h
@@ -110,13 +110,6 @@ class AMDGPUSubtarget {
/// size, register usage, and/or lds usage.
std::pair<unsigned, unsigned> getWavesPerEU(const Function &F) const;
- /// Overload which uses the specified values for the flat work group sizes,
- /// rather than querying the function itself. \p FlatWorkGroupSizes Should
- /// correspond to the function's value for getFlatWorkGroupSizes.
- std::pair<unsigned, unsigned>
- getWavesPerEU(const Function &F,
- std::pair<unsigned, unsigned> FlatWorkGroupSizes) const;
-
/// Overload which uses the specified values for the flat workgroup sizes and
/// LDS space rather than querying the function itself. \p FlatWorkGroupSizes
/// should correspond to the function's value for getFlatWorkGroupSizes and \p
``````````
</details>
https://github.com/llvm/llvm-project/pull/181131
More information about the llvm-commits
mailing list