[llvm] [SystemZ] Handle indirect symbols (PR #180815)

Ulrich Weigand via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 11 09:16:26 PST 2026


================
@@ -355,9 +371,12 @@ void SystemZHLASMAsmStreamer::finishImpl() {
     auto &Sym = static_cast<MCSymbolGOFF &>(const_cast<MCSymbol &>(Symbol));
     OS << " " << (Sym.isWeak() ? "WXTRN" : "EXTRN") << " " << Sym.getName();
     EmitEOL();
-    emitXATTR(OS, Sym.getName(), Sym.getLinkage(), Sym.getCodeData(),
-              Sym.getBindingScope());
-    EmitEOL();
+    emitXATTR(OS, Sym.getName(), Sym.isIndirect(), Sym.getLinkage(),
+              Sym.getCodeData(), Sym.getBindingScope());
----------------
uweigand wrote:

There is a bit of weirdness as to whether `emitXATTR` should be followed by `EmitEOL` or not - this should be used consistently.  Maybe the issue is `emitXATTR`  should not print an hard-coded newline, but rather call `EmitEOL` itself?

https://github.com/llvm/llvm-project/pull/180815


More information about the llvm-commits mailing list