[llvm] [AMDGPU] Fix LDS address correction in promoteConstantOffsetToImm for async stores (PR #180220)

via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 10 12:01:23 PST 2026


github-actions[bot] wrote:

<!--PREMERGE ADVISOR COMMENT: Linux-->
# :penguin: Linux x64 Test Results

* 169495 tests passed
* 3050 tests skipped
* 2 tests failed

## Failed Tests
(click on a test name to see its output)

### LLVM
<details>
<summary>LLVM.CodeGen/AMDGPU/promote-constOffset-to-imm-gfx12.ll</summary>

```
Exit Code: 1

Command Output (stdout):
--
# RUN: at line 2
/home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/llc -mtriple=amdgcn -mcpu=gfx1250 < /home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/test/CodeGen/AMDGPU/promote-constOffset-to-imm-gfx12.ll | /home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/FileCheck -check-prefixes=GFX1250 /home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/test/CodeGen/AMDGPU/promote-constOffset-to-imm-gfx12.ll
# executed command: /home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/llc -mtriple=amdgcn -mcpu=gfx1250
# .---command stderr------------
# | llc: /home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/lib/Target/AMDGPU/SILoadStoreOptimizer.cpp:2383: void (anonymous namespace)::SILoadStoreOptimizer::updateAsyncLDSAddress(MachineInstr &, int32_t) const: Assertion `LDSAddr' failed.
# | PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace and instructions to reproduce the bug.
# | Stack dump:
# | 0.	Program arguments: /home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/llc -mtriple=amdgcn -mcpu=gfx1250
# | 1.	Running pass 'CallGraph Pass Manager' on module '<stdin>'.
# | 2.	Running pass 'SI Load Store Optimizer' on function '@promote_async_store_offset_negative'
# |  #0 0x00000000083300c8 llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) /home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/lib/Support/Unix/Signals.inc:842:13
# |  #1 0x000000000832d7f5 llvm::sys::RunSignalHandlers() /home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/lib/Support/Signals.cpp:109:18
# |  #2 0x0000000008330e91 SignalHandler(int, siginfo_t*, void*) /home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/lib/Support/Unix/Signals.inc:429:38
# |  #3 0x00007dc62d9f7330 (/lib/x86_64-linux-gnu/libc.so.6+0x45330)
# |  #4 0x00007dc62da50b2c pthread_kill (/lib/x86_64-linux-gnu/libc.so.6+0x9eb2c)
# |  #5 0x00007dc62d9f727e raise (/lib/x86_64-linux-gnu/libc.so.6+0x4527e)
# |  #6 0x00007dc62d9da8ff abort (/lib/x86_64-linux-gnu/libc.so.6+0x288ff)
# |  #7 0x00007dc62d9da81b (/lib/x86_64-linux-gnu/libc.so.6+0x2881b)
# |  #8 0x00007dc62d9ed517 (/lib/x86_64-linux-gnu/libc.so.6+0x3b517)
# |  #9 0x0000000005744bc5 getReg /home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/include/llvm/CodeGen/MachineOperand.h:373:5
# | #10 0x0000000005744bc5 (anonymous namespace)::SILoadStoreOptimizer::updateAsyncLDSAddress(llvm::MachineInstr&, int) const /home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/lib/Target/AMDGPU/SILoadStoreOptimizer.cpp:2385:30
# | #11 0x00000000057420c2 promoteConstantOffsetToImm /home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/lib/Target/AMDGPU/SILoadStoreOptimizer.cpp:2529:5
# | #12 0x00000000057420c2 collectMergeableInsts /home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/lib/Target/AMDGPU/SILoadStoreOptimizer.cpp:2581:9
# | #13 0x00000000057420c2 (anonymous namespace)::SILoadStoreOptimizer::run(llvm::MachineFunction&) /home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/lib/Target/AMDGPU/SILoadStoreOptimizer.cpp:2821:11
# | #14 0x0000000005743d10 (anonymous namespace)::SILoadStoreOptimizerLegacy::runOnMachineFunction(llvm::MachineFunction&) /home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/lib/Target/AMDGPU/SILoadStoreOptimizer.cpp:2789:1
# | #15 0x0000000006ff8ad3 llvm::MachineFunctionPass::runOnFunction(llvm::Function&) /home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/lib/CodeGen/MachineFunctionPass.cpp:0:10
# | #16 0x00000000075693c5 llvm::FPPassManager::runOnFunction(llvm::Function&) /home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/lib/IR/LegacyPassManager.cpp:1398:27
# | #17 0x0000000006a9c2a4 RunPassOnSCC /home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/lib/Analysis/CallGraphSCCPass.cpp:180:25
# | #18 0x0000000006a9c2a4 RunAllPassesOnSCC /home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/lib/Analysis/CallGraphSCCPass.cpp:469:9
# | #19 0x0000000006a9c2a4 (anonymous namespace)::CGPassManager::runOnModule(llvm::Module&) /home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/lib/Analysis/CallGraphSCCPass.cpp:534:18
# | #20 0x0000000007569e6c runOnModule /home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/lib/IR/LegacyPassManager.cpp:1513:27
# | #21 0x0000000007569e6c llvm::legacy::PassManagerImpl::run(llvm::Module&) /home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/lib/IR/LegacyPassManager.cpp:531:44
# | #22 0x0000000004da966f compileModule(char**, llvm::SmallVectorImpl<llvm::PassPlugin>&, llvm::LLVMContext&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>&) /home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/tools/llc/llc.cpp:871:17
# | #23 0x0000000004da6943 main /home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/tools/llc/llc.cpp:459:13
# | #24 0x00007dc62d9dc1ca (/lib/x86_64-linux-gnu/libc.so.6+0x2a1ca)
# | #25 0x00007dc62d9dc28b __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x2a28b)
# | #26 0x0000000004da2465 _start (/home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/llc+0x4da2465)
# `-----------------------------
# error: command failed with exit status: -6
# executed command: /home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/FileCheck -check-prefixes=GFX1250 /home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/test/CodeGen/AMDGPU/promote-constOffset-to-imm-gfx12.ll
# .---command stderr------------
# | /home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/test/CodeGen/AMDGPU/promote-constOffset-to-imm-gfx12.ll:103:18: error: GFX1250-LABEL: expected string not found in input
# | ; GFX1250-LABEL: promote_async_store_offset_negative:
# |                  ^
# | <stdin>:86:36: note: scanning from here
# | promote_async_load_offset_positive: ; @promote_async_load_offset_positive
# |                                    ^
# | <stdin>:86:40: note: possible intended match here
# | promote_async_load_offset_positive: ; @promote_async_load_offset_positive
# |                                        ^
# | 
# | Input file: <stdin>
# | Check file: /home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/test/CodeGen/AMDGPU/promote-constOffset-to-imm-gfx12.ll
# | 
# | -dump-input=help explains the following input dump.
# | 
# | Input was:
# | <<<<<<
# |              .
# |              .
# |              .
# |             81:  .long 0 
# |             82:  .text 
# |             83:  .globl promote_async_load_offset_positive ; -- Begin function promote_async_load_offset_positive 
# |             84:  .p2align 8 
# |             85:  .type promote_async_load_offset_positive, at function 
# |             86: promote_async_load_offset_positive: ; @promote_async_load_offset_positive 
# | label:103'0                                        X~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ error: no match found
# | label:103'1                                            ?                                   possible intended match
# |             87: ; %bb.0: ; %entry 
# | label:103'0     ~~~~~~~~~~~~~~~~~~
# |             88:  s_setreg_imm32_b32 hwreg(HW_REG_WAVE_MODE, 25, 1), 1 
# | label:103'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# |             89:  s_load_b64 s[0:1], s[4:5], 0x24 nv 
# | label:103'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# |             90:  v_mov_b32_e32 v1, 0 
# | label:103'0     ~~~~~~~~~~~~~~~~~~~~~
# |             91:  v_and_b32_e32 v0, 0x3ff, v0 
# | label:103'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# |              .
# |              .
# |              .
# | >>>>>>
# `-----------------------------
# error: command failed with exit status: 1

--

```
</details>
<details>
<summary>LLVM.CodeGen/AMDGPU/promote-constOffset-to-imm-gfx12.mir</summary>

```
Exit Code: 2

Command Output (stdout):
--
# RUN: at line 2
/home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/llc -mtriple=amdgcn -mcpu=gfx1250 -start-before=si-load-store-opt -stop-before=si-insert-waitcnts -o - /home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/test/CodeGen/AMDGPU/promote-constOffset-to-imm-gfx12.mir | /home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/FileCheck -check-prefixes=GFX1250 /home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/test/CodeGen/AMDGPU/promote-constOffset-to-imm-gfx12.mir
# executed command: /home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/llc -mtriple=amdgcn -mcpu=gfx1250 -start-before=si-load-store-opt -stop-before=si-insert-waitcnts -o - /home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/test/CodeGen/AMDGPU/promote-constOffset-to-imm-gfx12.mir
# .---command stderr------------
# | llc: /home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/lib/Target/AMDGPU/SILoadStoreOptimizer.cpp:2383: void (anonymous namespace)::SILoadStoreOptimizer::updateAsyncLDSAddress(MachineInstr &, int32_t) const: Assertion `LDSAddr' failed.
# | PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace and instructions to reproduce the bug.
# | Stack dump:
# | 0.	Program arguments: /home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/llc -mtriple=amdgcn -mcpu=gfx1250 -start-before=si-load-store-opt -stop-before=si-insert-waitcnts -o - /home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/test/CodeGen/AMDGPU/promote-constOffset-to-imm-gfx12.mir
# | 1.	Running pass 'Function Pass Manager' on module '/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/test/CodeGen/AMDGPU/promote-constOffset-to-imm-gfx12.mir'.
# | 2.	Running pass 'SI Load Store Optimizer' on function '@promote_async_store_offset'
# |  #0 0x00000000083300c8 llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) /home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/lib/Support/Unix/Signals.inc:842:13
# |  #1 0x000000000832d7f5 llvm::sys::RunSignalHandlers() /home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/lib/Support/Signals.cpp:109:18
# |  #2 0x0000000008330e91 SignalHandler(int, siginfo_t*, void*) /home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/lib/Support/Unix/Signals.inc:429:38
# |  #3 0x00007ead61f6d330 (/lib/x86_64-linux-gnu/libc.so.6+0x45330)
# |  #4 0x00007ead61fc6b2c pthread_kill (/lib/x86_64-linux-gnu/libc.so.6+0x9eb2c)
# |  #5 0x00007ead61f6d27e raise (/lib/x86_64-linux-gnu/libc.so.6+0x4527e)
# |  #6 0x00007ead61f508ff abort (/lib/x86_64-linux-gnu/libc.so.6+0x288ff)
# |  #7 0x00007ead61f5081b (/lib/x86_64-linux-gnu/libc.so.6+0x2881b)
# |  #8 0x00007ead61f63517 (/lib/x86_64-linux-gnu/libc.so.6+0x3b517)
# |  #9 0x0000000005744bc5 getReg /home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/include/llvm/CodeGen/MachineOperand.h:373:5
# | #10 0x0000000005744bc5 (anonymous namespace)::SILoadStoreOptimizer::updateAsyncLDSAddress(llvm::MachineInstr&, int) const /home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/lib/Target/AMDGPU/SILoadStoreOptimizer.cpp:2385:30
# | #11 0x00000000057420c2 promoteConstantOffsetToImm /home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/lib/Target/AMDGPU/SILoadStoreOptimizer.cpp:2529:5
# | #12 0x00000000057420c2 collectMergeableInsts /home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/lib/Target/AMDGPU/SILoadStoreOptimizer.cpp:2581:9
# | #13 0x00000000057420c2 (anonymous namespace)::SILoadStoreOptimizer::run(llvm::MachineFunction&) /home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/lib/Target/AMDGPU/SILoadStoreOptimizer.cpp:2821:11
# | #14 0x0000000005743d10 (anonymous namespace)::SILoadStoreOptimizerLegacy::runOnMachineFunction(llvm::MachineFunction&) /home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/lib/Target/AMDGPU/SILoadStoreOptimizer.cpp:2789:1
# | #15 0x0000000006ff8ad3 llvm::MachineFunctionPass::runOnFunction(llvm::Function&) /home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/lib/CodeGen/MachineFunctionPass.cpp:0:10
# | #16 0x00000000075693c5 llvm::FPPassManager::runOnFunction(llvm::Function&) /home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/lib/IR/LegacyPassManager.cpp:1398:27
# | #17 0x0000000007571372 llvm::FPPassManager::runOnModule(llvm::Module&) /home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/lib/IR/LegacyPassManager.cpp:1444:13
# | #18 0x0000000007569e6c runOnModule /home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/lib/IR/LegacyPassManager.cpp:1513:27
# | #19 0x0000000007569e6c llvm::legacy::PassManagerImpl::run(llvm::Module&) /home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/lib/IR/LegacyPassManager.cpp:531:44
# | #20 0x0000000004da966f compileModule(char**, llvm::SmallVectorImpl<llvm::PassPlugin>&, llvm::LLVMContext&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>&) /home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/tools/llc/llc.cpp:871:17
# | #21 0x0000000004da6943 main /home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/tools/llc/llc.cpp:459:13
# | #22 0x00007ead61f521ca (/lib/x86_64-linux-gnu/libc.so.6+0x2a1ca)
# | #23 0x00007ead61f5228b __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x2a28b)
# | #24 0x0000000004da2465 _start (/home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/llc+0x4da2465)
# `-----------------------------
# error: command failed with exit status: -6
# executed command: /home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/FileCheck -check-prefixes=GFX1250 /home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/test/CodeGen/AMDGPU/promote-constOffset-to-imm-gfx12.mir
# .---command stderr------------
# | FileCheck error: '<stdin>' is empty.
# | FileCheck command line:  /home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/FileCheck -check-prefixes=GFX1250 /home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/test/CodeGen/AMDGPU/promote-constOffset-to-imm-gfx12.mir
# `-----------------------------
# error: command failed with exit status: 2

--

```
</details>

If these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the `infrastructure` label.

https://github.com/llvm/llvm-project/pull/180220


More information about the llvm-commits mailing list