[llvm] [ValueLattice][SCCP] Consider provenance for predicate-derived pointer constants (PR #160083)

[Antonio Frighetto via llvm-commits]

================
@@ -356,11 +379,12 @@ bool SCCPSolver::simplifyInstsInBlock(BasicBlock &BB,
     if (Inst.getType()->isVoidTy())
       continue;
     if (tryToReplaceWithConstant(&Inst)) {
-      if (wouldInstructionBeTriviallyDead(&Inst))
+      if (isInstructionTriviallyDead(&Inst)) {
----------------
antoniofrighetto wrote:

As long as the instruction is dead, that should be fine. Though now we should set MadeChanges only upon actual erasing.

https://github.com/llvm/llvm-project/pull/160083