[llvm] [NFC] Modify the comment of LoopRotate param (PR #180675)
Pengcheng Wang via llvm-commits
llvm-commits at lists.llvm.org
Tue Feb 10 00:31:09 PST 2026
https://github.com/wangpc-pp updated https://github.com/llvm/llvm-project/pull/180675
>From d1a89db5af37fcd15b71c9f90a58098be1f3bbed Mon Sep 17 00:00:00 2001
From: shining <shiningning at iscas.ac.cn>
Date: Tue, 10 Feb 2026 04:33:31 +0000
Subject: [PATCH 1/2] [NFC] Modify the comment of LoopRotate param
---
llvm/lib/Passes/PassBuilderPipelines.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/llvm/lib/Passes/PassBuilderPipelines.cpp b/llvm/lib/Passes/PassBuilderPipelines.cpp
index 675d941c39c13..60a587a503520 100644
--- a/llvm/lib/Passes/PassBuilderPipelines.cpp
+++ b/llvm/lib/Passes/PassBuilderPipelines.cpp
@@ -512,7 +512,7 @@ PassBuilder::buildO1FunctionSimplificationPipeline(OptimizationLevel Level,
LPM1.addPass(LICMPass(PTO.LicmMssaOptCap, PTO.LicmMssaNoAccForPromotionCap,
/*AllowSpeculation=*/false));
- LPM1.addPass(LoopRotatePass(/* Disable header duplication */ true,
+ LPM1.addPass(LoopRotatePass(/* Enable header duplication */ true,
isLTOPreLink(Phase)));
// TODO: Investigate promotion cap for O1.
LPM1.addPass(LICMPass(PTO.LicmMssaOptCap, PTO.LicmMssaNoAccForPromotionCap,
>From eb55a0fe6b7488e5b9c61d4f8af65db70518bb3e Mon Sep 17 00:00:00 2001
From: Pengcheng Wang <wangpengcheng.pp at bytedance.com>
Date: Tue, 10 Feb 2026 16:31:01 +0800
Subject: [PATCH 2/2] Apply suggestion from @wangpc-pp
---
llvm/lib/Passes/PassBuilderPipelines.cpp | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/llvm/lib/Passes/PassBuilderPipelines.cpp b/llvm/lib/Passes/PassBuilderPipelines.cpp
index 60a587a503520..123541a985454 100644
--- a/llvm/lib/Passes/PassBuilderPipelines.cpp
+++ b/llvm/lib/Passes/PassBuilderPipelines.cpp
@@ -512,8 +512,8 @@ PassBuilder::buildO1FunctionSimplificationPipeline(OptimizationLevel Level,
LPM1.addPass(LICMPass(PTO.LicmMssaOptCap, PTO.LicmMssaNoAccForPromotionCap,
/*AllowSpeculation=*/false));
- LPM1.addPass(LoopRotatePass(/* Enable header duplication */ true,
- isLTOPreLink(Phase)));
+ LPM1.addPass(
+ LoopRotatePass(/*EnableHeaderDuplication=*/true, isLTOPreLink(Phase)));
// TODO: Investigate promotion cap for O1.
LPM1.addPass(LICMPass(PTO.LicmMssaOptCap, PTO.LicmMssaNoAccForPromotionCap,
/*AllowSpeculation=*/true));
More information about the llvm-commits
mailing list