[llvm] [AMDGPU][SIInsertWaitcnt][NFC] Access Waitcnt elements using InstCounterType (PR #178345)

Jay Foad via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 9 10:46:09 PST 2026


jayfoad wrote:

> > Any particular reason you split the single switch in getCounterRef into two separate switches?
> 
> > I still think that, eventually, we should use array indexing instead of switches.
> 
> The switches will be replaced by array accesses in a followup patch.
> 
> @jayfoad regarding your comment about avoiding `using namespace llvm::AMDGPU`, given that not adding it will result in a much larger patch, do you think it would be OK to land this as is and do the namespace cleanup in a separate patch ?

Sure, I guess it's OK for now.

https://github.com/llvm/llvm-project/pull/178345


More information about the llvm-commits mailing list