[llvm] [NFC][Core][CodeGen] Remove pass initialization from pass constructors (PR #180153)

[via llvm-commits]

llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-llvm-ir

Author: Rahul Joshi (jurahul)

<details>
<summary>Changes</summary>



---
Full diff: https://github.com/llvm/llvm-project/pull/180153.diff


6 Files Affected:

- (modified) llvm/lib/CodeGen/CodeGen.cpp (+2) 
- (modified) llvm/lib/CodeGen/GlobalMergeFunctions.cpp (+1-6) 
- (modified) llvm/lib/CodeGen/InsertCodePrefetch.cpp (+1-3) 
- (modified) llvm/lib/IR/Dominators.cpp (+1-3) 
- (modified) llvm/lib/IR/SafepointIRVerifier.cpp (+1-3) 
- (modified) llvm/lib/IR/Verifier.cpp (+2-7) 


``````````diff
diff --git a/llvm/lib/CodeGen/CodeGen.cpp b/llvm/lib/CodeGen/CodeGen.cpp
index 0fb1c744407e2..fec9a3db20142 100644
--- a/llvm/lib/CodeGen/CodeGen.cpp
+++ b/llvm/lib/CodeGen/CodeGen.cpp
@@ -56,10 +56,12 @@ void llvm::initializeCodeGen(PassRegistry &Registry) {
   initializeGCMachineCodeAnalysisPass(Registry);
   initializeGCModuleInfoPass(Registry);
   initializeGlobalMergePass(Registry);
+  initializeGlobalMergeFuncPassWrapperPass(Registry);
   initializeHardwareLoopsLegacyPass(Registry);
   initializeIfConverterPass(Registry);
   initializeImplicitNullChecksPass(Registry);
   initializeIndirectBrExpandLegacyPassPass(Registry);
+  initializeInsertCodePrefetchPass(Registry);
   initializeInitUndefLegacyPass(Registry);
   initializeInterleavedLoadCombinePass(Registry);
   initializeInterleavedAccessPass(Registry);
diff --git a/llvm/lib/CodeGen/GlobalMergeFunctions.cpp b/llvm/lib/CodeGen/GlobalMergeFunctions.cpp
index 81ab317c15889..320a7a57ce8b8 100644
--- a/llvm/lib/CodeGen/GlobalMergeFunctions.cpp
+++ b/llvm/lib/CodeGen/GlobalMergeFunctions.cpp
@@ -571,7 +571,7 @@ class GlobalMergeFuncPassWrapper : public ModulePass {
 public:
   static char ID;
 
-  GlobalMergeFuncPassWrapper();
+  GlobalMergeFuncPassWrapper() : ModulePass(ID) {}
 
   void getAnalysisUsage(AnalysisUsage &AU) const override {
     AU.addUsedIfAvailable<ImmutableModuleSummaryIndexWrapperPass>();
@@ -594,11 +594,6 @@ ModulePass *llvm::createGlobalMergeFuncPass() {
   return new GlobalMergeFuncPassWrapper();
 }
 
-GlobalMergeFuncPassWrapper::GlobalMergeFuncPassWrapper() : ModulePass(ID) {
-  initializeGlobalMergeFuncPassWrapperPass(
-      *llvm::PassRegistry::getPassRegistry());
-}
-
 bool GlobalMergeFuncPassWrapper::runOnModule(Module &M) {
   const ModuleSummaryIndex *Index = nullptr;
   if (auto *IndexWrapperPass =
diff --git a/llvm/lib/CodeGen/InsertCodePrefetch.cpp b/llvm/lib/CodeGen/InsertCodePrefetch.cpp
index 44864cbc99c52..d54e4408a0dcb 100644
--- a/llvm/lib/CodeGen/InsertCodePrefetch.cpp
+++ b/llvm/lib/CodeGen/InsertCodePrefetch.cpp
@@ -36,9 +36,7 @@ class InsertCodePrefetch : public MachineFunctionPass {
 public:
   static char ID;
 
-  InsertCodePrefetch() : MachineFunctionPass(ID) {
-    initializeInsertCodePrefetchPass(*PassRegistry::getPassRegistry());
-  }
+  InsertCodePrefetch() : MachineFunctionPass(ID) {}
 
   StringRef getPassName() const override {
     return "Code Prefetch Inserter Pass";
diff --git a/llvm/lib/IR/Dominators.cpp b/llvm/lib/IR/Dominators.cpp
index e1e88bb2aaff5..7bd1cef88dbaf 100644
--- a/llvm/lib/IR/Dominators.cpp
+++ b/llvm/lib/IR/Dominators.cpp
@@ -419,9 +419,7 @@ PreservedAnalyses DominatorTreeVerifierPass::run(Function &F,
 
 char DominatorTreeWrapperPass::ID = 0;
 
-DominatorTreeWrapperPass::DominatorTreeWrapperPass() : FunctionPass(ID) {
-  initializeDominatorTreeWrapperPassPass(*PassRegistry::getPassRegistry());
-}
+DominatorTreeWrapperPass::DominatorTreeWrapperPass() : FunctionPass(ID) {}
 
 INITIALIZE_PASS(DominatorTreeWrapperPass, "domtree",
                 "Dominator Tree Construction", true, true)
diff --git a/llvm/lib/IR/SafepointIRVerifier.cpp b/llvm/lib/IR/SafepointIRVerifier.cpp
index e35b5b30a7cc1..d3dba17de2b0e 100644
--- a/llvm/lib/IR/SafepointIRVerifier.cpp
+++ b/llvm/lib/IR/SafepointIRVerifier.cpp
@@ -209,9 +209,7 @@ namespace {
 
 struct SafepointIRVerifier : public FunctionPass {
   static char ID; // Pass identification, replacement for typeid
-  SafepointIRVerifier() : FunctionPass(ID) {
-    initializeSafepointIRVerifierPass(*PassRegistry::getPassRegistry());
-  }
+  SafepointIRVerifier() : FunctionPass(ID) {}
 
   bool runOnFunction(Function &F) override {
     auto &DT = getAnalysis<DominatorTreeWrapperPass>().getDomTree();
diff --git a/llvm/lib/IR/Verifier.cpp b/llvm/lib/IR/Verifier.cpp
index 120a7daa16f05..3f0f6c127b456 100644
--- a/llvm/lib/IR/Verifier.cpp
+++ b/llvm/lib/IR/Verifier.cpp
@@ -7909,14 +7909,9 @@ struct VerifierLegacyPass : public FunctionPass {
   std::unique_ptr<Verifier> V;
   bool FatalErrors = true;
 
-  VerifierLegacyPass() : FunctionPass(ID) {
-    initializeVerifierLegacyPassPass(*PassRegistry::getPassRegistry());
-  }
+  VerifierLegacyPass() : FunctionPass(ID) {}
   explicit VerifierLegacyPass(bool FatalErrors)
-      : FunctionPass(ID),
-        FatalErrors(FatalErrors) {
-    initializeVerifierLegacyPassPass(*PassRegistry::getPassRegistry());
-  }
+      : FunctionPass(ID), FatalErrors(FatalErrors) {}
 
   bool doInitialization(Module &M) override {
     V = std::make_unique<Verifier>(

``````````

</details>


https://github.com/llvm/llvm-project/pull/180153