[llvm] [AMDGPU][SIInsertWaitcnt][NFC] Don't expose internal data structure to user (PR #179736)

[Jay Foad via llvm-commits]

================
@@ -523,9 +521,9 @@ class WaitcntGeneratorPreGFX12 final : public WaitcntGenerator {
                         AMDGPU::Waitcnt Wait,
                         const WaitcntBrackets &ScoreBrackets) override;
 
-  const WaitEventSet *getWaitEventMask() const override {
+  const WaitEventSet &getWaitEvents(InstCounterType T) const override {
     assert(ST);
----------------
jayfoad wrote:

Could you please do a separate patch to clean up this assert? There is no particular reason to put it here, and furthermore, now that WaitcntGenerator cannot be default constructed, members ST and TII can be references instead of pointers.

https://github.com/llvm/llvm-project/pull/179736