[clang] [llvm] [Clang][inlineasm] Add special support for "rm" output constraints (PR #92040)
Nick Desaulniers via llvm-commits
llvm-commits at lists.llvm.org
Wed Feb 4 11:51:02 PST 2026
nickdesaulniers wrote:
Yeah, I think merging this with CallBrPrepare (and renaming the result to
something sensible) would be good.
On Wed, Feb 4, 2026, 11:35 AM Bill Wendling ***@***.***>
wrote:
> ***@***.**** commented on this pull request.
> ------------------------------
>
> In llvm/lib/CodeGen/InlineAsmPrepare.cpp
> <https://github.com/llvm/llvm-project/pull/92040#discussion_r2765594528>:
>
> > + IsOutput = true;
> + ++I;
> + }
> + if (*I == '*') {
> + Out << '*';
> + HasIndirect = true;
> + ++I;
> + }
> + if (*I == '+') {
> + Out << '+';
> + IsOutput = true;
> + ++I;
> + }
> +
> + auto Comma = std::find(I, E, ',');
> + std::string Sub(I, Comma);
>
> It looks like StringRef doesn't accept the interator + offset pairing...
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/llvm/llvm-project/pull/92040#discussion_r2765594528>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAN5IX6OCWQXOPXGVKQWC3D4KJCVXAVCNFSM6AAAAACPUWSYHGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTONJSHA4DSMZTGU>
> .
> You are receiving this because your review was requested.Message ID:
> ***@***.***>
>
https://github.com/llvm/llvm-project/pull/92040
More information about the llvm-commits
mailing list