[llvm] [Github] Fully remove use of login_or_token (PR #179258)
via llvm-commits
llvm-commits at lists.llvm.org
Mon Feb 2 07:38:49 PST 2026
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-github-workflow
Author: Aiden Grossman (boomanaiden154)
<details>
<summary>Changes</summary>
PyGithub deprecated this a while back. An earlier patch attempted to fix all the deprecations, but it looks like my grep expression missed a bunch of cases. This patch should catch the remaining ones (minus libc++ which have been split for review by libc++ maintainers).
---
Full diff: https://github.com/llvm/llvm-project/pull/179258.diff
6 Files Affected:
- (modified) .ci/premerge_advisor_explain.py (+3-1)
- (modified) .github/workflows/commit-create-issue.py (+1-1)
- (modified) llvm/utils/git/code-format-helper.py (+1-1)
- (modified) llvm/utils/git/code-lint-helper.py (+1-1)
- (modified) llvm/utils/git/github-automation.py (+18-10)
- (modified) llvm/utils/release/github-upload-release.py (+2-2)
``````````diff
diff --git a/.ci/premerge_advisor_explain.py b/.ci/premerge_advisor_explain.py
index 6046905284cc4..f4153fa4a635c 100644
--- a/.ci/premerge_advisor_explain.py
+++ b/.ci/premerge_advisor_explain.py
@@ -33,7 +33,9 @@ def get_comment(
pr_number: int,
body: str,
) -> dict[str, str]:
- repo = github.Github(github_token).get_repo("llvm/llvm-project")
+ repo = github.Github(auth=github.Auth.Token(github_token)).get_repo(
+ "llvm/llvm-project"
+ )
pr = repo.get_issue(pr_number).as_pull_request()
body = COMMENT_TAG.format(platform=platform.system()) + "\n" + body
comment = {"body": body}
diff --git a/.github/workflows/commit-create-issue.py b/.github/workflows/commit-create-issue.py
index 62bc76cd1b9b6..5ffed8ad799ab 100644
--- a/.github/workflows/commit-create-issue.py
+++ b/.github/workflows/commit-create-issue.py
@@ -2,7 +2,7 @@
import sys
token = sys.argv[1]
-gh = github.Github(login_or_token=token)
+gh = github.Github(auth=github.Auth.Token(token))
repo = gh.get_repo("llvm/llvm-project")
length = "4 weeks"
diff --git a/llvm/utils/git/code-format-helper.py b/llvm/utils/git/code-format-helper.py
index f6b28f480b8a2..1e8c332554a8e 100755
--- a/llvm/utils/git/code-format-helper.py
+++ b/llvm/utils/git/code-format-helper.py
@@ -124,7 +124,7 @@ def update_pr(self, comment_text: str, args: FormatArgs, create_new: bool) -> No
import github
from github import IssueComment, PullRequest
- repo = github.Github(args.token).get_repo(args.repo)
+ repo = github.Github(auth=github.Auth.Token(args.token)).get_repo(args.repo)
pr = repo.get_issue(args.issue_number).as_pull_request()
comment_text = self.comment_tag + "\n\n" + comment_text
diff --git a/llvm/utils/git/code-lint-helper.py b/llvm/utils/git/code-lint-helper.py
index 6f2afc9b2ad06..954ed45713ade 100644
--- a/llvm/utils/git/code-lint-helper.py
+++ b/llvm/utils/git/code-lint-helper.py
@@ -111,7 +111,7 @@ def find_comment(self, pr: Any) -> Any:
def update_pr(self, comment_text: str, args: LintArgs, create_new: bool) -> None:
assert args.repo is not None
- repo = github.Github(args.token).get_repo(args.repo)
+ repo = github.Github(auth=github.Auth.Token(args.token)).get_repo(args.repo)
pr = repo.get_issue(args.issue_number).as_pull_request()
comment_text = f"{self.comment_tag}\n\n{comment_text}"
diff --git a/llvm/utils/git/github-automation.py b/llvm/utils/git/github-automation.py
index b766aa505a62e..6414a073d9c4b 100755
--- a/llvm/utils/git/github-automation.py
+++ b/llvm/utils/git/github-automation.py
@@ -66,8 +66,10 @@ def team_name(self) -> str:
return self._team_name
def __init__(self, token: str, repo: str, issue_number: int, label_name: str):
- self.repo = github.Github(token).get_repo(repo)
- self.org = github.Github(token).get_organization(self.repo.organization.login)
+ self.repo = github.Github(auth=github.Auth.Token(token)).get_repo(repo)
+ self.org = github.Github(auth=github.Auth.Token(token)).get_organization(
+ self.repo.organization.login
+ )
self.issue = self.repo.get_issue(issue_number)
self._team_name = "issue-subscribers-{}".format(label_name).lower()
@@ -111,8 +113,10 @@ def team_name(self) -> str:
return self._team_name
def __init__(self, token: str, repo: str, pr_number: int, label_name: str):
- self.repo = github.Github(token).get_repo(repo)
- self.org = github.Github(token).get_organization(self.repo.organization.login)
+ self.repo = github.Github(auth=github.Auth.Token(token)).get_repo(repo)
+ self.org = github.Github(auth=github.Auth.Token(token)).get_organization(
+ self.repo.organization.login
+ )
self.pr = self.repo.get_issue(pr_number).as_pull_request()
self._team_name = "pr-subscribers-{}".format(
label_name.replace("+", "x")
@@ -230,7 +234,7 @@ class PRGreeter:
COMMENT_TAG = "<!--LLVM NEW CONTRIBUTOR COMMENT-->\n"
def __init__(self, token: str, repo: str, pr_number: int):
- repo = github.Github(token).get_repo(repo)
+ repo = github.Github(auth=github.Auth.Token(token)).get_repo(repo)
self.pr = repo.get_issue(pr_number).as_pull_request()
def run(self) -> bool:
@@ -260,7 +264,7 @@ def run(self) -> bool:
class CommitRequestGreeter:
def __init__(self, token: str, repo: str, issue_number: int):
- self.repo = github.Github(token).get_repo(repo)
+ self.repo = github.Github(auth=github.Auth.Token(token)).get_repo(repo)
self.issue = self.repo.get_issue(issue_number)
def run(self) -> bool:
@@ -323,7 +327,7 @@ class PRBuildbotInformation:
COMMENT_TAG = "<!--LLVM BUILDBOT INFORMATION COMMENT-->\n"
def __init__(self, token: str, repo: str, pr_number: int, author: str):
- repo = github.Github(token).get_repo(repo)
+ repo = github.Github(auth=github.Auth.Token(token)).get_repo(repo)
self.pr = repo.get_issue(pr_number).as_pull_request()
self.author = author
@@ -460,7 +464,9 @@ def requested_by(self) -> str:
@property
def repo(self) -> github.Repository.Repository:
- return github.Github(self.token).get_repo(self.repo_name)
+ return github.Github(auth=github.Auth.Token(self.token)).get_repo(
+ self.repo_name
+ )
@property
def issue(self) -> github.Issue.Issue:
@@ -725,7 +731,9 @@ def create_pull_request(
https://docs.github.com/en/get-started/quickstart/github-glossary#base-branch
https://docs.github.com/en/get-started/quickstart/github-glossary#compare-branch
"""
- repo = github.Github(self.token).get_repo(self.repo_name)
+ repo = github.Github(auth=github.Auth.Token(self.token)).get_repo(
+ self.repo_name
+ )
issue_ref = "{}#{}".format(self.repo_name, self.issue_number)
pull = None
release_branch_for_issue = self.release_branch_for_issue
@@ -800,7 +808,7 @@ def execute_command(self) -> bool:
def request_release_note(token: str, repo_name: str, pr_number: int):
- repo = github.Github(token).get_repo(repo_name)
+ repo = github.Github(auth=github.Auth.Token(token)).get_repo(repo_name)
pr = repo.get_issue(pr_number).as_pull_request()
submitter = pr.user.login
if submitter == "llvmbot":
diff --git a/llvm/utils/release/github-upload-release.py b/llvm/utils/release/github-upload-release.py
index 2d8fb4531eb51..8aa39d3600c19 100755
--- a/llvm/utils/release/github-upload-release.py
+++ b/llvm/utils/release/github-upload-release.py
@@ -280,7 +280,7 @@ def uncomment_download_links(repo, release_version):
args = parser.parse_args()
-gh = github.Github(args.token)
+gh = github.Github(auth=github.Auth.Token(args.token))
llvm_org = gh.get_organization("llvm")
llvm_repo = llvm_org.get_repo("llvm-project")
@@ -291,7 +291,7 @@ def uncomment_download_links(repo, release_version):
# Validate that this user is allowed to modify releases.
user = gh.get_user(args.user)
team = (
- github.Github(args.user_token)
+ github.Github(auth=github.Auth.Token(args.user_token))
.get_organization("llvm")
.get_team_by_slug("llvm-release-managers")
)
``````````
</details>
https://github.com/llvm/llvm-project/pull/179258
More information about the llvm-commits
mailing list