[llvm] [DebugInfo] Convert format() to formatv() in DWARFVerifier (PR #179194)

[Konrad Kleine via llvm-commits]

kwk wrote:

> Majority of it is fine and it is easier to understand in the vast majority of cases.

Good.

> I wish we could have the Python `{var_name}` kinda thing but not an option here.

I've attended @AaronBallman 's office hours a while back and there this was discussed: https://brevzin.github.io/cpp_proposals/3951_string_interpolation/p3951r0.html. I think this is somewhat related to what you're proposing. But you're right, I wish we had this but not an option here.

> So there are some cases where moving from `error() << "something: " << something` to `formatv("something: {0})` is a slight regression but it makes the more complex cases so much easier to read, I think it's a small price to pay.

Agreed.

> Idk what balance you want to strike between keeping the formatv comprehensible and not having too many `<< thing`s but I've highlighted some places I think you can put a bit more in the formatv.

Thank you for that. I've addressed those and will additionally take a look at it myself again.



https://github.com/llvm/llvm-project/pull/179194