[llvm] [ReachingDefAnalysis] Simpilify `getGlobalReachingDefs` (PR #175235)

Mikhail Gudim via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 9 12:11:42 PST 2026


https://github.com/mgudim created https://github.com/llvm/llvm-project/pull/175235

This call to getUniqueReachingMIDef` was an overkill. Replace it with simpler `getReachingLocalMIDef`.

>From 6266a85a697ba49b78a220f7c6419ad67edffe44 Mon Sep 17 00:00:00 2001
From: Mikhail Gudim <mgudim at qti.qualcomm.com>
Date: Thu, 8 Jan 2026 15:01:22 -0800
Subject: [PATCH] [ReachingDefAnalysis] Simpilify `getGlobalReachingDefs`

This call to getUniqueReachingMIDef` was an overkill. Replace it with simpler
`getReachingLocalMIDef`.
---
 llvm/lib/CodeGen/ReachingDefAnalysis.cpp | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/llvm/lib/CodeGen/ReachingDefAnalysis.cpp b/llvm/lib/CodeGen/ReachingDefAnalysis.cpp
index b12a5bc64ca0b..37f571008acd5 100644
--- a/llvm/lib/CodeGen/ReachingDefAnalysis.cpp
+++ b/llvm/lib/CodeGen/ReachingDefAnalysis.cpp
@@ -533,8 +533,9 @@ void ReachingDefInfo::getGlobalUses(MachineInstr *MI, Register Reg,
 
 void ReachingDefInfo::getGlobalReachingDefs(MachineInstr *MI, Register Reg,
                                             InstSet &Defs) const {
-  if (auto *Def = getUniqueReachingMIDef(MI, Reg)) {
-    Defs.insert(Def);
+  // If there's a local def before MI, return it.
+  if (MachineInstr *LocalDef = getReachingLocalMIDef(MI, Reg)) {
+    Defs.insert(LocalDef);
     return;
   }
 



More information about the llvm-commits mailing list