[llvm] 7f5dbbc - [Utils][update_mc_test_checks] Handle double quotes in asm source (#175161)

via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 9 06:04:04 PST 2026


Author: Jay Foad
Date: 2026-01-09T14:04:00Z
New Revision: 7f5dbbc342756a0ca65acc214c41c0162276c1fd

URL: https://github.com/llvm/llvm-project/commit/7f5dbbc342756a0ca65acc214c41c0162276c1fd
DIFF: https://github.com/llvm/llvm-project/commit/7f5dbbc342756a0ca65acc214c41c0162276c1fd.diff

LOG: [Utils][update_mc_test_checks] Handle double quotes in asm source (#175161)

Added: 
    

Modified: 
    llvm/test/tools/UpdateTestChecks/update_mc_test_checks/Inputs/amdgpu_asm.s
    llvm/test/tools/UpdateTestChecks/update_mc_test_checks/Inputs/amdgpu_asm.s.expected
    llvm/utils/update_mc_test_checks.py

Removed: 
    


################################################################################
diff  --git a/llvm/test/tools/UpdateTestChecks/update_mc_test_checks/Inputs/amdgpu_asm.s b/llvm/test/tools/UpdateTestChecks/update_mc_test_checks/Inputs/amdgpu_asm.s
index b21935e1d1a3a..6d4b2a6cbe5f6 100644
--- a/llvm/test/tools/UpdateTestChecks/update_mc_test_checks/Inputs/amdgpu_asm.s
+++ b/llvm/test/tools/UpdateTestChecks/update_mc_test_checks/Inputs/amdgpu_asm.s
@@ -1,3 +1,5 @@
 // RUN: llvm-mc -triple=amdgcn -show-encoding %s 2>&1 | FileCheck --check-prefixes=CHECK %s
 
 v_bfrev_b32 v5, v1
+
+ds_swizzle_b32 v8, v2 offset:swizzle(BITMASK_PERM, "01pip")

diff  --git a/llvm/test/tools/UpdateTestChecks/update_mc_test_checks/Inputs/amdgpu_asm.s.expected b/llvm/test/tools/UpdateTestChecks/update_mc_test_checks/Inputs/amdgpu_asm.s.expected
index 2dc30cd112e46..e193d12fd1f01 100644
--- a/llvm/test/tools/UpdateTestChecks/update_mc_test_checks/Inputs/amdgpu_asm.s.expected
+++ b/llvm/test/tools/UpdateTestChecks/update_mc_test_checks/Inputs/amdgpu_asm.s.expected
@@ -3,3 +3,6 @@
 
 v_bfrev_b32 v5, v1
 // CHECK: v_bfrev_b32_e32 v5, v1                  ; encoding: [0x01,0x71,0x0a,0x7e]
+
+ds_swizzle_b32 v8, v2 offset:swizzle(BITMASK_PERM, "01pip")
+// CHECK: ds_swizzle_b32 v8, v2 offset:swizzle(BITMASK_PERM,"01pip") ; encoding: [0x07,0x09,0xd4,0xd8,0x02,0x00,0x00,0x08]

diff  --git a/llvm/utils/update_mc_test_checks.py b/llvm/utils/update_mc_test_checks.py
index 9b80267e8ad8c..43b756c289b7b 100755
--- a/llvm/utils/update_mc_test_checks.py
+++ b/llvm/utils/update_mc_test_checks.py
@@ -38,6 +38,7 @@ def invoke_tool(exe, check_rc, cmd_args, testline, verbose=False):
     substs = SUBSTITUTIONS + [(t, exe) for t in mc_LIKE_TOOLS]
     args = [common.applySubstitutions(cmd, substs) for cmd in cmd_args.split("|")]
 
+    testline = testline.replace('"', '\\"')
     cmd = 'echo "' + testline + '" | ' + exe + " " + " | ".join(args)
     if verbose:
         print("Command: ", cmd)


        


More information about the llvm-commits mailing list