[llvm] [Utils][update_mc_test_checks] Handle double quotes in asm source (PR #175161)
Jay Foad via llvm-commits
llvm-commits at lists.llvm.org
Fri Jan 9 04:22:05 PST 2026
https://github.com/jayfoad created https://github.com/llvm/llvm-project/pull/175161
None
>From a73f684597d9efd64dd1c1848d3ead3989dcb51d Mon Sep 17 00:00:00 2001
From: Jay Foad <jay.foad at amd.com>
Date: Fri, 9 Jan 2026 12:17:54 +0000
Subject: [PATCH] [Utils][update_mc_test_checks] Handle double quotes in asm
source
---
.../UpdateTestChecks/update_mc_test_checks/Inputs/amdgpu_asm.s | 2 ++
.../update_mc_test_checks/Inputs/amdgpu_asm.s.expected | 3 +++
llvm/utils/update_mc_test_checks.py | 2 +-
3 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/llvm/test/tools/UpdateTestChecks/update_mc_test_checks/Inputs/amdgpu_asm.s b/llvm/test/tools/UpdateTestChecks/update_mc_test_checks/Inputs/amdgpu_asm.s
index b21935e1d1a3a..6d4b2a6cbe5f6 100644
--- a/llvm/test/tools/UpdateTestChecks/update_mc_test_checks/Inputs/amdgpu_asm.s
+++ b/llvm/test/tools/UpdateTestChecks/update_mc_test_checks/Inputs/amdgpu_asm.s
@@ -1,3 +1,5 @@
// RUN: llvm-mc -triple=amdgcn -show-encoding %s 2>&1 | FileCheck --check-prefixes=CHECK %s
v_bfrev_b32 v5, v1
+
+ds_swizzle_b32 v8, v2 offset:swizzle(BITMASK_PERM, "01pip")
diff --git a/llvm/test/tools/UpdateTestChecks/update_mc_test_checks/Inputs/amdgpu_asm.s.expected b/llvm/test/tools/UpdateTestChecks/update_mc_test_checks/Inputs/amdgpu_asm.s.expected
index 2dc30cd112e46..e193d12fd1f01 100644
--- a/llvm/test/tools/UpdateTestChecks/update_mc_test_checks/Inputs/amdgpu_asm.s.expected
+++ b/llvm/test/tools/UpdateTestChecks/update_mc_test_checks/Inputs/amdgpu_asm.s.expected
@@ -3,3 +3,6 @@
v_bfrev_b32 v5, v1
// CHECK: v_bfrev_b32_e32 v5, v1 ; encoding: [0x01,0x71,0x0a,0x7e]
+
+ds_swizzle_b32 v8, v2 offset:swizzle(BITMASK_PERM, "01pip")
+// CHECK: ds_swizzle_b32 v8, v2 offset:swizzle(BITMASK_PERM,"01pip") ; encoding: [0x07,0x09,0xd4,0xd8,0x02,0x00,0x00,0x08]
diff --git a/llvm/utils/update_mc_test_checks.py b/llvm/utils/update_mc_test_checks.py
index 9b80267e8ad8c..ebe04de7c9a8a 100755
--- a/llvm/utils/update_mc_test_checks.py
+++ b/llvm/utils/update_mc_test_checks.py
@@ -38,7 +38,7 @@ def invoke_tool(exe, check_rc, cmd_args, testline, verbose=False):
substs = SUBSTITUTIONS + [(t, exe) for t in mc_LIKE_TOOLS]
args = [common.applySubstitutions(cmd, substs) for cmd in cmd_args.split("|")]
- cmd = 'echo "' + testline + '" | ' + exe + " " + " | ".join(args)
+ cmd = 'echo "' + testline.replace('"', '\\"') + '" | ' + exe + " " + " | ".join(args)
if verbose:
print("Command: ", cmd)
More information about the llvm-commits
mailing list