[llvm] [CodeGen][NFC] Improve readability of getLocalLiveOutMIDef (PR #175074)

Mikhail Gudim via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 8 13:36:58 PST 2026


https://github.com/mgudim created https://github.com/llvm/llvm-project/pull/175074

Reorder some code to make it less confusing.

>From f01073d7c3f13fd84456c6934eff25166cab3fa7 Mon Sep 17 00:00:00 2001
From: Mikhail Gudim <mgudim at qti.qualcomm.com>
Date: Thu, 8 Jan 2026 13:30:12 -0800
Subject: [PATCH] [CodeGen][NFC] Improve readability of getLocalLiveOutMIDef

Reorder some code to make it less confusing.
---
 llvm/lib/CodeGen/ReachingDefAnalysis.cpp | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/llvm/lib/CodeGen/ReachingDefAnalysis.cpp b/llvm/lib/CodeGen/ReachingDefAnalysis.cpp
index b12a5bc64ca0b..b8b35210413ff 100644
--- a/llvm/lib/CodeGen/ReachingDefAnalysis.cpp
+++ b/llvm/lib/CodeGen/ReachingDefAnalysis.cpp
@@ -663,18 +663,18 @@ MachineInstr *ReachingDefInfo::getLocalLiveOutMIDef(MachineBasicBlock *MBB,
   if (Last == MBB->end())
     return nullptr;
 
+  // Check if Last is the definition
   if (Reg.isStack()) {
     int FrameIndex = Reg.stackSlotIndex();
     if (isFIDef(*Last, FrameIndex, TII))
       return &*Last;
+  } else {
+    for (auto &MO : Last->operands())
+      if (isValidRegDefOf(MO, Reg, TRI))
+        return &*Last;
   }
 
   int Def = getReachingDef(&*Last, Reg);
-
-  for (auto &MO : Last->operands())
-    if (isValidRegDefOf(MO, Reg, TRI))
-      return &*Last;
-
   return Def < 0 ? nullptr : getInstFromId(MBB, Def);
 }
 



More information about the llvm-commits mailing list