[llvm] [AMDGPU] Fix a potential use-after-erase in `AMDGPUPromoteAlloca` pass (PR #174529)

[Shilei Tian via llvm-commits]

================
@@ -1166,9 +1166,18 @@ void AMDGPUPromoteAllocaImpl::promoteAllocaToVector(AllocaAnalysis &AA) {
   });
 
   // Now fixup the placeholders.
-  for (Instruction *Placeholder : Placeholders) {
-    Placeholder->replaceAllUsesWith(
-        Updater.GetValueInMiddleOfBlock(Placeholder->getParent()));
+  SmallVector<WeakVH> PlaceholderToNewVal(Placeholders.size());
----------------
shiltian wrote:

It is the other way around: we erase those values here, and `SSAUpdater` uses it later.

https://github.com/llvm/llvm-project/pull/174529