[llvm] Reland: [ORC] Tailor ELF debugger support plugin to load-address patching only (PR #169482)

[Lang Hames via llvm-commits]

Stefan =?utf-8?q?Gränitz?= <stefan.graenitz at gmail.com>,
Stefan =?utf-8?q?Gränitz?= <stefan.graenitz at gmail.com>,
Stefan =?utf-8?q?Gränitz?= <stefan.graenitz at gmail.com>,
Stefan =?utf-8?q?Gränitz?= <stefan.graenitz at gmail.com>,
Stefan =?utf-8?q?Gränitz?= <stefan.graenitz at gmail.com>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/169482 at github.com>


================
@@ -348,6 +348,16 @@ class SimpleSegmentAlloc {
     return Alloc->finalize();
   }
 
+  /// Free allocated memory if finalize won't be called.
+  Error abandon() {
+    Error Err = Error::success();
+    Alloc->abandon([&Err](Error E) {
+      ErrorAsOutParameter _(&Err);
+      Err = std::move(E);
+    });
+    return Err;
----------------
lhames wrote:

This is unsafe as the callback may not be run on the same thread.

The goal going forward is for all ORC operations that could trigger IPC / RPC to be non-blocking. The blocking helpers may end up being deprecated and removed (except in top-level convenience APIs like LLJIT).



https://github.com/llvm/llvm-project/pull/169482