[llvm] [Orc][LibResolver] Refactor resolver internals and simplify symbol resolution. (PR #169161)

[via llvm-commits]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff origin/main HEAD --extensions h,cpp -- llvm/include/llvm/ExecutionEngine/Orc/TargetProcess/LibraryResolver.h llvm/include/llvm/ExecutionEngine/Orc/TargetProcess/LibraryScanner.h llvm/lib/ExecutionEngine/Orc/TargetProcess/LibraryResolver.cpp llvm/lib/ExecutionEngine/Orc/TargetProcess/LibraryScanner.cpp llvm/unittests/ExecutionEngine/Orc/LibraryResolverTest.cpp --diff_from_common_commit
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/llvm/lib/ExecutionEngine/Orc/TargetProcess/LibraryScanner.cpp b/llvm/lib/ExecutionEngine/Orc/TargetProcess/LibraryScanner.cpp
index 025da92d0..e74568e6b 100644
--- a/llvm/lib/ExecutionEngine/Orc/TargetProcess/LibraryScanner.cpp
+++ b/llvm/lib/ExecutionEngine/Orc/TargetProcess/LibraryScanner.cpp
@@ -65,15 +65,14 @@ static std::string getHostFileFormatName() {
 }
 
 bool ObjectFileLoader::isArchitectureCompatible(const object::ObjectFile &Obj) {
-  return  Obj.getFileFormatName() == getHostFileFormatName();
+  return Obj.getFileFormatName() == getHostFileFormatName();
 }
 
 Expected<object::OwningBinary<object::ObjectFile>>
 ObjectFileLoader::loadObjectFileWithOwnership(StringRef FilePath) {
   LLVM_DEBUG(dbgs() << "ObjectFileLoader: Attempting to open file " << FilePath
                     << "\n";);
-  if (auto ObjOrErr =
-          object::ObjectFile::createObjectFile(FilePath)) {
+  if (auto ObjOrErr = object::ObjectFile::createObjectFile(FilePath)) {
 
     LLVM_DEBUG(dbgs() << "ObjectFileLoader: Detected object file\n";);
 
@@ -157,8 +156,8 @@ ObjectFileLoader::loadObjectFileWithOwnership(StringRef FilePath) {
   }
 
   return createStringError(inconvertibleErrorCode(),
-                          "Not a compatible object file : %s",
-                          FilePath.str().c_str());
+                           "Not a compatible object file : %s",
+                           FilePath.str().c_str());
 }
 
 template <class ELFT>

``````````

</details>


https://github.com/llvm/llvm-project/pull/169161