[llvm] Multi platofmr test fork (PR #170554)
via llvm-commits
llvm-commits at lists.llvm.org
Wed Dec 3 12:44:46 PST 2025
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-github-workflow
@llvm/pr-subscribers-infrastructure
Author: Aiden Grossman (boomanaiden154)
<details>
<summary>Changes</summary>
---
Full diff: https://github.com/llvm/llvm-project/pull/170554.diff
4 Files Affected:
- (modified) .ci/premerge_advisor_explain.py (+2-1)
- (modified) .github/workflows/issue-write-test.yaml (+10-4)
- (modified) .github/workflows/issue-write.yml (+6-1)
- (modified) .github/workflows/premerge.yaml (+10-2)
``````````diff
diff --git a/.ci/premerge_advisor_explain.py b/.ci/premerge_advisor_explain.py
index 155e91bef55f8..bd65eb3d1588b 100644
--- a/.ci/premerge_advisor_explain.py
+++ b/.ci/premerge_advisor_explain.py
@@ -129,7 +129,8 @@ def main(
# If the job succeeds and there is not an existing comment, we
# should not write one to reduce noise.
comments = []
- with open("comments", "w") as comment_file_handle:
+ comments_file_name = f"comments-{platform.system()}-{platform.machine()}"
+ with open(comments_file_name, "w") as comment_file_handle:
json.dump(comments, comment_file_handle)
diff --git a/.github/workflows/issue-write-test.yaml b/.github/workflows/issue-write-test.yaml
index 422a369fe0185..c976c9378e8f4 100644
--- a/.github/workflows/issue-write-test.yaml
+++ b/.github/workflows/issue-write-test.yaml
@@ -12,14 +12,20 @@ jobs:
test-issue-write:
name: "Test Issue Write"
runs-on: ubuntu-24.04
- if: github.repository == 'llvm/llvm-project'
steps:
- name: Write Comment
run: |
- echo '[{"body": "This is a comment for testing the issue write workflow"}]' > comments
+ echo '[{"body": "This is a comment for testing the issue write workflow"}]' > comments-foo
+ echo '[{"body": "This is another comment for testing the issue write workflow that was placed in a separate file"}]' > comments-bar
- name: Upload Comment
uses: actions/upload-artifact at 330a01c490aca151604b8cf639adc76d48f6c5d4 # v5.0.0
with:
- name: workflow-args
+ name: workflow-args-foo
path: |
- comments
+ comments-foo
+ - name: Upload Comment
+ uses: actions/upload-artifact at 330a01c490aca151604b8cf639adc76d48f6c5d4 # v5.0.0
+ with:
+ name: workflow-args-bar
+ path: |
+ comments-bar
diff --git a/.github/workflows/issue-write.yml b/.github/workflows/issue-write.yml
index ac75dffd8b3b8..9ceadbe971093 100644
--- a/.github/workflows/issue-write.yml
+++ b/.github/workflows/issue-write.yml
@@ -47,7 +47,12 @@ jobs:
github-token: ${{ secrets.GITHUB_TOKEN }}
script: |
var fs = require('fs');
- const comments = JSON.parse(fs.readFileSync('./comments'));
+ var comments = []
+ for (local_file of fs.readdirSync('.')) {
+ if (local_file.startsWith("comments")) {
+ comments.push(...JSON.parse(fs.readFileSync(local_file)))
+ }
+ }
if (!comments || comments.length == 0) {
return;
}
diff --git a/.github/workflows/premerge.yaml b/.github/workflows/premerge.yaml
index 10f7f6a827b30..4ea5397edbeac 100644
--- a/.github/workflows/premerge.yaml
+++ b/.github/workflows/premerge.yaml
@@ -124,9 +124,9 @@ jobs:
if: ${{ always() && !startsWith(matrix.runs-on, 'depot-ubuntu-24.04-arm') }}
continue-on-error: true
with:
- name: workflow-args
+ name: workflow-args-x86-linux
path: |
- comments
+ comments-Linux-x86_64
premerge-checks-windows:
name: Build and Test Windows
@@ -185,6 +185,14 @@ jobs:
path: artifacts/
retention-days: 5
include-hidden-files: 'true'
+ - name: Upload Comment
+ uses: actions/upload-artifact at 330a01c490aca151604b8cf639adc76d48f6c5d4 # v5.0.0
+ if: always()
+ continue-on-error: true
+ with:
+ name: workflow-args-windows
+ path: |
+ comments-Windows-x86_64
premerge-check-macos:
name: MacOS Premerge Checks
``````````
</details>
https://github.com/llvm/llvm-project/pull/170554
More information about the llvm-commits
mailing list