[clang-tools-extra] [llvm] [Github][CI] Add `doc8` for clang-tidy documentation formatting (PR #168827)

[Baranov Victor via llvm-commits]

================
@@ -18,98 +18,101 @@
 """
 
 import argparse
+import github
+import json
 import os
 import subprocess
 import sys
-from typing import List, Optional
+from typing import Any, Dict, Final, List, Sequence
 
 
 class LintArgs:
-    start_rev: str = None
-    end_rev: str = None
-    repo: str = None
-    changed_files: List[str] = []
-    token: str = None
-    verbose: bool = True
-    issue_number: int = 0
-    build_path: str = "build"
-    clang_tidy_binary: str = "clang-tidy"
-
-    def __init__(self, args: argparse.Namespace = None) -> None:
+    __start_rev: str
+    __end_rev: str
+    __repo: str
+    __changed_files: List[str]
+    __token: str
+    __verbose: bool
+    __issue_number: int
+    __build_path: str
+    __clang_tidy_binary: str
----------------
vbvictor wrote:

I personally don't understand why we need this change with `__`.
I get the idea behind "privateness" here but here we essentially wrote 3 times more code for very little no benefit (we rarely change scripts anyway).

Also, same style is used here
https://github.com/llvm/llvm-project/blob/main/llvm/utils/git/code-format-helper.py#L41-L49

So I really don't want these classes to differ.
Can we leave it as is @EugeneZelenko?
CC @boomanaiden154.

Apart from it, refactor patch looks good.

https://github.com/llvm/llvm-project/pull/168827