[llvm] [CI] Add checkmark emojis for passing builds (PR #170183)

Aiden Grossman via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 1 11:05:21 PST 2025


https://github.com/boomanaiden154 updated https://github.com/llvm/llvm-project/pull/170183

>From ac1ff140c9fd61e4569bbe9dbc056768e2292356 Mon Sep 17 00:00:00 2001
From: Aiden Grossman <aidengrossman at google.com>
Date: Mon, 1 Dec 2025 18:56:30 +0000
Subject: [PATCH 1/2] [CI] Add checkmark emojis for passing builds

This better matches the code formatter and I personally find the visual
indication valuable when I am scrolling/glancing at a comment.
---
 .ci/generate_test_report_lib.py      | 6 ++++--
 .ci/generate_test_report_lib_test.py | 6 ++++--
 2 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/.ci/generate_test_report_lib.py b/.ci/generate_test_report_lib.py
index ce8262f0dc73f..10529c26ec337 100644
--- a/.ci/generate_test_report_lib.py
+++ b/.ci/generate_test_report_lib.py
@@ -184,8 +184,8 @@ def generate_report(
         if return_code == 0:
             report.extend(
                 [
-                    "The build succeeded and no tests ran. This is expected in some "
-                    "build configurations."
+                    ":white_check_mark: The build succeeded and no tests ran. "
+                    "This is expected in some build configurations."
                 ]
             )
         else:
@@ -272,6 +272,8 @@ def plural(num_tests):
                 ]
             )
             report.extend(_format_failures(ninja_failures, failure_explanations))
+    else:
+        report.extend(["", ":white_check_mark: The build succeeded and all tests passed."])
 
     if failures or return_code != 0:
         report.extend(["", UNRELATED_FAILURES_STR])
diff --git a/.ci/generate_test_report_lib_test.py b/.ci/generate_test_report_lib_test.py
index 341cf3037b921..182af1d52641a 100644
--- a/.ci/generate_test_report_lib_test.py
+++ b/.ci/generate_test_report_lib_test.py
@@ -194,7 +194,7 @@ def test_title_only(self):
                 """\
                 # Foo
 
-                The build succeeded and no tests ran. This is expected in some build configurations."""
+                :white_check_mark: The build succeeded and no tests ran. This is expected in some build configurations."""
             ),
         )
 
@@ -308,7 +308,9 @@ def test_no_failures(self):
                     """\
               # Foo
 
-              * 1 test passed"""
+              * 1 test passed
+              
+              :white_check_mark: The build succeeded and all tests passed."""
                 )
             ),
         )

>From 6a472a9759d951d3b7d42a9e2c4d3e912db510fd Mon Sep 17 00:00:00 2001
From: Aiden Grossman <aidengrossman at google.com>
Date: Mon, 1 Dec 2025 19:05:10 +0000
Subject: [PATCH 2/2] formatting

---
 .ci/generate_test_report_lib.py | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/.ci/generate_test_report_lib.py b/.ci/generate_test_report_lib.py
index 10529c26ec337..c62c901fe46f5 100644
--- a/.ci/generate_test_report_lib.py
+++ b/.ci/generate_test_report_lib.py
@@ -273,7 +273,9 @@ def plural(num_tests):
             )
             report.extend(_format_failures(ninja_failures, failure_explanations))
     else:
-        report.extend(["", ":white_check_mark: The build succeeded and all tests passed."])
+        report.extend(
+            ["", ":white_check_mark: The build succeeded and all tests passed."]
+        )
 
     if failures or return_code != 0:
         report.extend(["", UNRELATED_FAILURES_STR])



More information about the llvm-commits mailing list