[llvm] [BOLT] Do not fail in case of instrumentation binary without fini & fini_array & instrumentation-sleep-time>0 (PR #170086)

Peter Waller via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 1 01:05:14 PST 2025


================
@@ -1507,6 +1508,10 @@ Error RewriteInstance::discoverRtFiniAddress() {
   }
 
   if (!BC->FiniArrayAddress || !BC->FiniArraySize) {
+    // it is not mandatory to have finalization hooks if we have
+    // InstrumentationSleepTime>0
----------------
peterwaller-arm wrote:

Style nit: comments ideally start with capitals. Suggested comment one-liner which doesn't require a line wrap:

> `// Missing hooks are allowed if when -instrumentation-sleep-time is in use.`

https://github.com/llvm/llvm-project/pull/170086


More information about the llvm-commits mailing list