[llvm] d7dcc10 - [GitHub] Add review instructions for commit access requests (#168971)

[via llvm-commits]

Author: Ellis Hoag
Date: 2025-11-25T10:22:23-08:00
New Revision: d7dcc108fc3ada2330277424495b676d52de1765

URL: https://github.com/llvm/llvm-project/commit/d7dcc108fc3ada2330277424495b676d52de1765
DIFF: https://github.com/llvm/llvm-project/commit/d7dcc108fc3ada2330277424495b676d52de1765.diff

LOG: [GitHub] Add review instructions for commit access requests (#168971)

As discussed in
https://discourse.llvm.org/t/clarification-on-how-to-accept-commit-access-requests/88728,
clarify reviewer instructions for how to accept commit access requests.

Added: 
    

Modified: 
    llvm/docs/DeveloperPolicy.rst
    llvm/utils/git/github-automation.py

Removed: 
    


################################################################################
diff  --git a/llvm/docs/DeveloperPolicy.rst b/llvm/docs/DeveloperPolicy.rst
index 9135406c2e2a1..2287698d4afbc 100644
--- a/llvm/docs/DeveloperPolicy.rst
+++ b/llvm/docs/DeveloperPolicy.rst
@@ -526,7 +526,10 @@ Most commonly these reviewers will provide the necessary approval, but approvals
 from other LLVM committers are also acceptable. Those reviewing the application are
 confirming that you have indeed had three patches committed, and that based on interactions
 on those reviews and elsewhere in the LLVM community they have no concern about you
-adhering to our Developer Policy and Code of Conduct.
+adhering to our Developer Policy and Code of Conduct. Reviewers should clearly state their
+reasoning for accepting or rejecting the request, and finish with a clear statement such
+as "I approve of this request", "LGTM", or "I do not approve of this request".
+
 
 If approved, a GitHub invitation will be sent to your
 GitHub account. In case you don't get notification from GitHub, go to

diff  --git a/llvm/utils/git/github-automation.py b/llvm/utils/git/github-automation.py
index 948788d501d1d..6e4417ec85819 100755
--- a/llvm/utils/git/github-automation.py
+++ b/llvm/utils/git/github-automation.py
@@ -305,6 +305,8 @@ def run(self) -> bool:
             * [{merged_prs} Merged Pull Requests]({merged_prs_url})
             * Top 3 Committers: {get_user_values_str(get_top_values(merged_by))}
             * Top 3 Reviewers: {get_user_values_str(get_top_values(reviewed_by))}
+
+            Reviewers should clearly state their reasoning for accepting or rejecting this request, and finish with a clear statement such as \"I approve of this request\", \"LGTM\", or \"I do not approve of this request\". Please review the instructions for [obtaining commit access](https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access).
         """
         self.issue.create_comment(textwrap.dedent(comment))