[llvm] [NFC][LLVM] Code cleanup in RegionPrinter (PR #166622)

[LLVM Continuous Integration via llvm-commits]

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `llvm-clang-x86_64-sie-ubuntu-fast` running on `sie-linux-worker` while building `llvm` at step 5 "build-unified-tree".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/144/builds/39523

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 5 (build-unified-tree) failure: build (failure)
...
0.026 [1504/4/11] Building StmtDataCollectors.inc...
0.026 [1504/3/12] Building BuiltinTemplates.inc...
0.037 [146/5/13] Generating VCSRevision.h
0.047 [139/11/14] Building Opcodes.inc...
0.062 [131/10/15] Generating VCSVersion.inc
0.064 [130/10/16] Linking CXX executable bin/llvm-config
0.107 [130/9/17] Building OpenCLBuiltins.inc...
0.621 [127/9/18] Building CXX object tools/clang/lib/Basic/CMakeFiles/obj.clangBasic.dir/Version.cpp.o
2.412 [127/8/19] Building CXX object lib/Object/CMakeFiles/LLVMObject.dir/IRSymtab.cpp.o
2.438 [126/8/20] Building CXX object lib/Analysis/CMakeFiles/LLVMAnalysis.dir/RegionPrinter.cpp.o
FAILED: lib/Analysis/CMakeFiles/LLVMAnalysis.dir/RegionPrinter.cpp.o 
CCACHE_CPP2=yes CCACHE_HASHDIR=yes CCACHE_SLOPPINESS=pch_defines,time_macros /usr/bin/ccache /usr/bin/g++ -DGTEST_HAS_RTTI=0 -DHAS_LOGF128 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GLIBCXX_USE_CXX11_ABI=1 -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/build/lib/Analysis -I/home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/llvm-project/llvm/lib/Analysis -I/home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/build/include -I/home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/llvm-project/llvm/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-array-bounds -Wno-stringop-overread -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -std=c++17 -MD -MT lib/Analysis/CMakeFiles/LLVMAnalysis.dir/RegionPrinter.cpp.o -MF lib/Analysis/CMakeFiles/LLVMAnalysis.dir/RegionPrinter.cpp.o.d -o lib/Analysis/CMakeFiles/LLVMAnalysis.dir/RegionPrinter.cpp.o -c /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/llvm-project/llvm/lib/Analysis/RegionPrinter.cpp
/home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/llvm-project/llvm/lib/Analysis/RegionPrinter.cpp:48:8: error: explicit specialization of ‘template<class Ty> struct llvm::DOTGraphTraits’ outside its namespace must use a nested-name-specifier [-fpermissive]
   48 | struct DOTGraphTraits<RegionInfo *>
      |        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
2.489 [126/7/21] Linking CXX static library lib/libLLVMObject.a
3.963 [126/6/22] Building CXX object lib/Analysis/CMakeFiles/LLVMAnalysis.dir/RegionInfo.cpp.o
4.266 [126/5/23] Building CXX object tools/bugpoint/CMakeFiles/bugpoint.dir/bugpoint.cpp.o
8.046 [126/4/24] Building CXX object tools/opt/CMakeFiles/LLVMOptDriver.dir/optdriver.cpp.o
9.153 [126/3/25] Building CXX object tools/clang/tools/driver/CMakeFiles/clang.dir/cc1_main.cpp.o
12.739 [126/2/26] Building CXX object lib/CodeGen/AsmPrinter/CMakeFiles/LLVMAsmPrinter.dir/AsmPrinter.cpp.o
In file included from /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/llvm-project/llvm/include/llvm/CodeGen/TargetLowering.h:32,
                 from /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/llvm-project/llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:62:
/home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/llvm-project/llvm/include/llvm/CodeGen/LibcallLoweringInfo.h:15:46: warning: ‘visibility’ attribute ignored [-Wattributes]
   15 |   LLVM_ABI const RTLIB::RuntimeLibcallsInfo &RTLCI;
      |                                              ^~~~~
/home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/llvm-project/llvm/include/llvm/CodeGen/LibcallLoweringInfo.h:18:25: warning: ‘visibility’ attribute ignored [-Wattributes]
   18 |       RTLIB::Unsupported};
      |                         ^
14.546 [126/1/27] Building CXX object lib/LTO/CMakeFiles/LLVMLTO.dir/LTO.cpp.o
ninja: build stopped: subcommand failed.

```

</details>

https://github.com/llvm/llvm-project/pull/166622