[llvm] [Support] Join threads when stopping the ThreadPoolExecutor (PR #166054)

[Maurice Heumann via llvm-commits]

momo5502 wrote:

> I'm not sure I follow how this fixes anything. If the `stop` method is not invoked, would the behaviour not be identical to the previous state? If so, how does this fix that?

You're right, this doesn't fix anything if the stop method is not invoked. This fix obviously requires the thread pool to be stopped outside the loader lock. llvm_shutdown does that, as the managed static construct invokes stop. So it requires calling llvm_shutdown.

https://github.com/llvm/llvm-project/pull/166054